diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2022-01-11 10:50:48 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-01-12 14:21:14 +0000 |
| commit | f7a6021aaf02088870559f82fc13c58cda7fea1a (patch) | |
| tree | ed0a9d92d080100871e37f1b6919e68daa71e3cc /sound | |
| parent | a64067f4cecaaa4deed8e33d3266bc0bcc189142 (diff) | |
| download | linux-rpi-f7a6021aaf02088870559f82fc13c58cda7fea1a.tar.gz linux-rpi-f7a6021aaf02088870559f82fc13c58cda7fea1a.tar.bz2 linux-rpi-f7a6021aaf02088870559f82fc13c58cda7fea1a.zip | |
ASoC: cpcap: Check for NULL pointer after calling of_get_child_by_name
If the device does not exist, of_get_child_by_name() will return NULL
pointer.
And devm_snd_soc_register_component() does not check it.
Also, I have noticed that cpcap_codec_driver has not been used yet.
Therefore, it should be better to check it in order to avoid the future
dereference of the NULL pointer.
Fixes: f6cdf2d3445d ("ASoC: cpcap: new codec")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220111025048.524134-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/cpcap.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/codecs/cpcap.c b/sound/soc/codecs/cpcap.c index 598e09024e23..ffdf8b615efa 100644 --- a/sound/soc/codecs/cpcap.c +++ b/sound/soc/codecs/cpcap.c @@ -1667,6 +1667,8 @@ static int cpcap_codec_probe(struct platform_device *pdev) { struct device_node *codec_node = of_get_child_by_name(pdev->dev.parent->of_node, "audio-codec"); + if (!codec_node) + return -ENODEV; pdev->dev.of_node = codec_node; |