diff options
author | Vakul Garg <vakul.garg@nxp.com> | 2019-03-12 08:22:57 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-03-13 14:16:44 -0700 |
commit | 4504ab0e6eb801555368cbb3011ab0530f659d4b (patch) | |
tree | 22c9992083d02f39318e454246b5ee55189cc9c3 /net/l2tp | |
parent | 5b5f99b186906d198f4455b3add911c87ab361fc (diff) | |
download | linux-rpi-4504ab0e6eb801555368cbb3011ab0530f659d4b.tar.gz linux-rpi-4504ab0e6eb801555368cbb3011ab0530f659d4b.tar.bz2 linux-rpi-4504ab0e6eb801555368cbb3011ab0530f659d4b.zip |
net/tls: Inform user space about send buffer availability
A previous fix ("tls: Fix write space handling") assumed that
user space application gets informed about the socket send buffer
availability when tls_push_sg() gets called. Inside tls_push_sg(), in
case do_tcp_sendpages() returns 0, the function returns without calling
ctx->sk_write_space. Further, the new function tls_sw_write_space()
did not invoke ctx->sk_write_space. This leads to situation that user
space application encounters a lockup always waiting for socket send
buffer to become available.
Rather than call ctx->sk_write_space from tls_push_sg(), it should be
called from tls_write_space. So whenever tcp stack invokes
sk->sk_write_space after freeing socket send buffer, we always declare
the same to user space by the way of invoking ctx->sk_write_space.
Fixes: 7463d3a2db0ef ("tls: Fix write space handling")
Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
Reviewed-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp')
0 files changed, 0 insertions, 0 deletions