diff options
| author | Jinjie Ruan <ruanjinjie@huawei.com> | 2024-10-16 09:24:53 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-11-08 16:28:23 +0100 |
| commit | 62c11896683129790b8f5ab6eb7e695818b0b723 (patch) | |
| tree | 1233b2ef47ef0dfd41e1c0dd97d143129dfcb4d1 /drivers | |
| parent | 3dc0eda2cd5c653b162852ae5f0631bfe4ca5e95 (diff) | |
| download | linux-rpi-62c11896683129790b8f5ab6eb7e695818b0b723.tar.gz linux-rpi-62c11896683129790b8f5ab6eb7e695818b0b723.tar.bz2 linux-rpi-62c11896683129790b8f5ab6eb7e695818b0b723.zip | |
iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table()
commit 369f05688911b05216cfcd6ca74473bec87948d7 upstream.
If per_time_scales[i] or per_time_gains[i] kcalloc fails in the for loop
of iio_gts_build_avail_scale_table(), the err_free_out will fail to call
kfree() each time when i is reduced to 0, so all the per_time_scales[0]
and per_time_gains[0] will not be freed, which will cause memory leaks.
Fix it by checking if i >= 0.
Cc: stable@vger.kernel.org
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20241016012453.2013302-1-ruanjinjie@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/iio/industrialio-gts-helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c index 59d7615c0f56..1aaa254aaf51 100644 --- a/drivers/iio/industrialio-gts-helper.c +++ b/drivers/iio/industrialio-gts-helper.c @@ -313,7 +313,7 @@ static int iio_gts_build_avail_scale_table(struct iio_gts *gts) return 0; err_free_out: - for (i--; i; i--) { + for (i--; i >= 0; i--) { kfree(per_time_scales[i]); kfree(per_time_gains[i]); } |