diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-05-19 20:42:30 +0900 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-06-06 09:01:12 +0900 |
commit | 6f0fa58e459642b16901521cc58ac474b787ec5b (patch) | |
tree | c7310820bb5745c1eb9475500b64e921262c6c0b /drivers/scsi/st_options.h | |
parent | 08332893e37af6ae779367e78e444f8f9571511d (diff) | |
download | linux-rpi-6f0fa58e459642b16901521cc58ac474b787ec5b.tar.gz linux-rpi-6f0fa58e459642b16901521cc58ac474b787ec5b.tar.bz2 linux-rpi-6f0fa58e459642b16901521cc58ac474b787ec5b.zip |
kbuild: simplify silent build (-s) detection
This allows to detect -s (--silent) option without checking GNU Make
version.
As commit e36aaea28972 ("kbuild: Fix silent builds with make-4")
pointed out, GNU Make 4.x changed the way/order it presents the
command line options into MAKEFLAGS.
In Make 3.8x, 's' is always the first in a group of short options.
The group may be prefixed with '-' in some cases.
In Make 4.x, 's' is always the last in a group of short options.
As commit e6ac89fabd03 ("kbuild: Correctly deal with make options
which contain an 's'") addressed, we also need to deal with long
options that contain 's', like --warn-undefined-variables.
Test cases:
[1] command line input: make --silent
-> MAKEFLAGS for Make 3.8x: s
-> MAKEFLAGS for Make 4.x : s
[2] command line input: make -srR
-> MAKEFLAGS for Make 3.8x: sRr
-> MAKEFLAGS for Make 4.x : rRs
[3] command line input: make -s -rR --warn-undefined-variables
-> MAKEFLAGS for Make 3.8x: --warn-undefined-variables -sRr
-> MAKEFLAGS for Make 4.x : rRs --warn-undefined-variables
My idea to cater to all the cases more easily is to filter out long
options (--%), then search 's' with $(findstring ...). This way will
be more future-proof even if future versions of Make put 's' in the
middle of the group.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Diffstat (limited to 'drivers/scsi/st_options.h')
0 files changed, 0 insertions, 0 deletions