diff options
| author | Mark Brown <broonie@kernel.org> | 2023-02-26 12:47:58 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-02-28 13:58:44 +0000 |
| commit | 8cbd7273a724d4e9615b26d696bb1221a8a48e4c (patch) | |
| tree | 170e771b2ef6ce07547033cc888ffdb0b43d7f72 | |
| parent | 8e847a43c28fca0aaa11fba8f91da7dfd9d6936f (diff) | |
| download | linux-rpi-8cbd7273a724d4e9615b26d696bb1221a8a48e4c.tar.gz linux-rpi-8cbd7273a724d4e9615b26d696bb1221a8a48e4c.tar.bz2 linux-rpi-8cbd7273a724d4e9615b26d696bb1221a8a48e4c.zip | |
ASoC: mt6358: Remove undefined HPx Mux enumeration values
The HPx Mux enumerations define values 5, 6 and 7 but describe them as
"undefined" and map them to the value 0 on writing. Given the descriptions
and behaviour it seems that these values are invalid and should not be
present in the register, the current behaviour is detected as problematic
by mixer-test:
# # HPL Mux.0 expected 5 but read 0, is_volatile 0
# # HPL Mux.0 expected 6 but read 0, is_volatile 0
# # HPL Mux.0 expected 7 but read 0, is_volatile 0
Remove the values from the enumeration, this will prevent userspace setting
them.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230224-asoc-mt6358-quick-fixes-v1-3-747d9186be4b@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/mt6358.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c index 89d0dcb2635b..b54610b27906 100644 --- a/sound/soc/codecs/mt6358.c +++ b/sound/soc/codecs/mt6358.c @@ -637,9 +637,6 @@ static const char * const hp_in_mux_map[] = { "Audio Playback", "Test Mode", "HP Impedance", - "undefined1", - "undefined2", - "undefined3", }; static int hp_in_mux_map_value[] = { @@ -648,9 +645,6 @@ static int hp_in_mux_map_value[] = { HP_MUX_HP, HP_MUX_TEST_MODE, HP_MUX_HP_IMPEDANCE, - HP_MUX_OPEN, - HP_MUX_OPEN, - HP_MUX_OPEN, }; static SOC_VALUE_ENUM_SINGLE_DECL(hpl_in_mux_map_enum, |