summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2020-08-19 13:02:01 +0200
committerDavid S. Miller <davem@davemloft.net>2020-08-19 13:03:03 -0700
commit52dbe8465e5b85263a4c28a48bc902e8c50b2f1b (patch)
tree48a142469b6dd4481fac2a33c5dc33ad9fa3561a
parentde993be0200ff4287b73beb440439b3d9472e644 (diff)
downloadlinux-rpi-52dbe8465e5b85263a4c28a48bc902e8c50b2f1b.tar.gz
linux-rpi-52dbe8465e5b85263a4c28a48bc902e8c50b2f1b.tar.bz2
linux-rpi-52dbe8465e5b85263a4c28a48bc902e8c50b2f1b.zip
r8169: use napi_complete_done return value
Consider the return value of napi_complete_done(), this allows users to use the gro_flush_timeout sysfs attribute as an alternative to classic interrupt coalescing. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/realtek/r8169_main.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index d1da92ac7fbe..dbc324c53b42 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4596,10 +4596,8 @@ static int rtl8169_poll(struct napi_struct *napi, int budget)
rtl_tx(dev, tp, budget);
- if (work_done < budget) {
- napi_complete_done(napi, work_done);
+ if (work_done < budget && napi_complete_done(napi, work_done))
rtl_irq_enable(tp);
- }
return work_done;
}