diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2020-04-09 12:43:45 -0500 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2020-04-14 19:16:51 -0500 |
commit | 0a8f41023e8a3c100b3dc458ed2da651bf961ead (patch) | |
tree | e6b5a2d7b1fdbce37b56d56ecd1949a3de6bb51c /MAINTAINERS | |
parent | 8f3d9f354286745c751374f5f1fcafee6b3f3136 (diff) | |
download | linux-riscv-0a8f41023e8a3c100b3dc458ed2da651bf961ead.tar.gz linux-riscv-0a8f41023e8a3c100b3dc458ed2da651bf961ead.tar.bz2 linux-riscv-0a8f41023e8a3c100b3dc458ed2da651bf961ead.zip |
PCI: Move Apex Edge TPU class quirk to fix BAR assignment
Some Google Apex Edge TPU devices have a class code of 0
(PCI_CLASS_NOT_DEFINED). This prevents the PCI core from assigning
resources for the Apex BARs because __dev_sort_resources() ignores
classless devices, host bridges, and IOAPICs.
On x86, firmware typically assigns those resources, so this was not a
problem. But on some architectures, firmware does *not* assign BARs, and
since the PCI core didn't do it either, the Apex device didn't work
correctly:
apex 0000:01:00.0: can't enable device: BAR 0 [mem 0x00000000-0x00003fff 64bit pref] not claimed
apex 0000:01:00.0: error enabling PCI device
f390d08d8b87 ("staging: gasket: apex: fixup undefined PCI class") added a
quirk to fix the class code, but it was in the apex driver, and if the
driver was built as a module, it was too late to help.
Move the quirk to the PCI core, where it will always run early enough that
the PCI core will assign resources if necessary.
Link: https://lore.kernel.org/r/CAEzXK1r0Er039iERnc2KJ4jn7ySNUOG9H=Ha8TD8XroVqiZjgg@mail.gmail.com
Fixes: f390d08d8b87 ("staging: gasket: apex: fixup undefined PCI class")
Reported-by: Luís Mendes <luis.p.mendes@gmail.com>
Debugged-by: Luís Mendes <luis.p.mendes@gmail.com>
Tested-by: Luis Mendes <luis.p.mendes@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Todd Poynor <toddpoynor@google.com>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions