summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorGerrit Renker <gerrit@erg.abdn.ac.uk>2007-11-24 21:58:33 -0200
committerDavid S. Miller <davem@davemloft.net>2008-01-28 14:54:55 -0800
commit900bfed4718126e6c32244903b6f43e0990d04ad (patch)
treed4644ea4770657046d762d9997d7a8e1d794ff94 /mm
parentb00d2bbc45a287c9a72374582ce42205f3412419 (diff)
downloadlinux-3.10-900bfed4718126e6c32244903b6f43e0990d04ad.tar.gz
linux-3.10-900bfed4718126e6c32244903b6f43e0990d04ad.tar.bz2
linux-3.10-900bfed4718126e6c32244903b6f43e0990d04ad.zip
[CCID2]: Disable broken Ack Ratio adaptation algorithm
This comments out a problematic section comprising a half-finished algorithm: - The variable `ccid2hctx_ackloss' is never initialised to a value different from 0 and hence in fact is a read-only constant. - The `arsent' variable counts packets other than Acks (it is incremented for every packet), and there is no test for Ack Loss. - The concept of counting Acks as such leads to a complex calculation, and the calculation at the moment is inconsistent with this concept. The problem is that the number of Acks - rather than the number of windows - is counted, which leads to a complex (cubic/quadratic) expression - this is not even implemented. In its current state, the commented-out algorithm interfers with normal processing by changing Ack Ratio incorrectly, and at the wrong times. A new algorithm is necessary, which will not necessarily use the same variables as used by the unfinished one; hence the old variables have been removed. Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions