diff options
| author | Yinghai Lu <yinghai@kernel.org> | 2013-11-18 17:02:45 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-04 10:57:04 -0800 |
| commit | cad6526a7a12079819b73c63cefdff076858830e (patch) | |
| tree | d28b2322186566d1f56f9a1d257d78bd82888c84 /include | |
| parent | 3733596c40dc8ef2be53b2945e978373d86312c6 (diff) | |
| download | linux-3.10-cad6526a7a12079819b73c63cefdff076858830e.tar.gz linux-3.10-cad6526a7a12079819b73c63cefdff076858830e.tar.bz2 linux-3.10-cad6526a7a12079819b73c63cefdff076858830e.zip | |
PCI: Remove duplicate pci_disable_device() from pcie_portdrv_remove()
commit e7cc5cf74544d97d7b69e2701595037474db1f96 upstream.
The pcie_portdrv .probe() method calls pci_enable_device() once, in
pcie_port_device_register(), but the .remove() method calls
pci_disable_device() twice, in pcie_port_device_remove() and in
pcie_portdrv_remove().
That causes a "disabling already-disabled device" warning when removing a
PCIe port device. This happens all the time when removing Thunderbolt
devices, but is also easy to reproduce with, e.g.,
"echo 0000:00:1c.3 > /sys/bus/pci/drivers/pcieport/unbind"
This patch removes the disable from pcie_portdrv_remove().
[bhelgaas: changelog, tag for stable]
Reported-by: David Bulkow <David.Bulkow@stratus.com>
Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions