diff options
author | Jeff Layton <jlayton@redhat.com> | 2012-07-11 09:09:35 -0400 |
---|---|---|
committer | Steve French <smfrench@gmail.com> | 2012-07-16 23:57:09 -0500 |
commit | 3ae629d98bd5ed77585a878566f04f310adbc591 (patch) | |
tree | 11a55d0bdca06f3a8d0b37df19e668a400c7a62c /fs/libfs.c | |
parent | ffc61ccbb96809df8d97ed609ac86b509eaf9056 (diff) | |
download | linux-3.10-3ae629d98bd5ed77585a878566f04f310adbc591.tar.gz linux-3.10-3ae629d98bd5ed77585a878566f04f310adbc591.tar.bz2 linux-3.10-3ae629d98bd5ed77585a878566f04f310adbc591.zip |
cifs: on CONFIG_HIGHMEM machines, limit the rsize/wsize to the kmap space
We currently rely on being able to kmap all of the pages in an async
read or write request. If you're on a machine that has CONFIG_HIGHMEM
set then that kmap space is limited, sometimes to as low as 512 slots.
With 512 slots, we can only support up to a 2M r/wsize, and that's
assuming that we can get our greedy little hands on all of them. There
are other users however, so it's possible we'll end up stuck with a
size that large.
Since we can't handle a rsize or wsize larger than that currently, cap
those options at the number of kmap slots we have. We could consider
capping it even lower, but we currently default to a max of 1M. Might as
well allow those luddites on 32 bit arches enough rope to hang
themselves.
A more robust fix would be to teach the send and receive routines how
to contend with an array of pages so we don't need to marshal up a kvec
array at all. That's a fairly significant overhaul though, so we'll need
this limit in place until that's ready.
Cc: <stable@vger.kernel.org>
Reported-by: Jian Li <jiali@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/libfs.c')
0 files changed, 0 insertions, 0 deletions