summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorRoland Dreier <rolandd@cisco.com>2006-05-17 09:16:03 -0700
committerRoland Dreier <rolandd@cisco.com>2006-05-17 09:16:03 -0700
commitec2d7208494fe599a5ff13b40a0a20c9881f2737 (patch)
tree32af58729f73b18d08fa8759a3408cb4058c6455 /drivers
parente65810566f3e613d9baa5512b8724ebde42ace0f (diff)
downloadlinux-3.10-ec2d7208494fe599a5ff13b40a0a20c9881f2737.tar.gz
linux-3.10-ec2d7208494fe599a5ff13b40a0a20c9881f2737.tar.bz2
linux-3.10-ec2d7208494fe599a5ff13b40a0a20c9881f2737.zip
IB/srp: Get rid of extra scsi_host_put()s if reconnection fails
If a reconnection attempt fails, then SRP does two scsi_host_put()s. This is a historical relic from an earlier version of the driver that took a reference on the scsi_host before trying to reconnect, so get rid of the extra scsi_host_put(). Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/infiniband/ulp/srp/ib_srp.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 351d66f3250..0f24f04cb60 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -354,7 +354,6 @@ static void srp_remove_work(void *target_ptr)
spin_lock_irq(target->scsi_host->host_lock);
if (target->state != SRP_TARGET_DEAD) {
spin_unlock_irq(target->scsi_host->host_lock);
- scsi_host_put(target->scsi_host);
return;
}
target->state = SRP_TARGET_REMOVED;
@@ -368,8 +367,6 @@ static void srp_remove_work(void *target_ptr)
ib_destroy_cm_id(target->cm_id);
srp_free_target_ib(target);
scsi_host_put(target->scsi_host);
- /* And another put to really free the target port... */
- scsi_host_put(target->scsi_host);
}
static int srp_connect_target(struct srp_target_port *target)