summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorSalva Peiró <speiro@ai2.upv.es>2013-10-16 12:46:50 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-11-04 04:31:04 -0800
commit8ffb77d881734108a750acb7fb2625643f924bc5 (patch)
treecb7ccf45395eddb82e052e20fbcb35cb793b5dd2 /drivers
parentc69ee66768490b30127bc496921a3603c9366a10 (diff)
downloadlinux-3.10-8ffb77d881734108a750acb7fb2625643f924bc5.tar.gz
linux-3.10-8ffb77d881734108a750acb7fb2625643f924bc5.tar.bz2
linux-3.10-8ffb77d881734108a750acb7fb2625643f924bc5.zip
wanxl: fix info leak in ioctl
[ Upstream commit 2b13d06c9584b4eb773f1e80bbaedab9a1c344e1 ] The wanxl_ioctl() code fails to initialize the two padding bytes of struct sync_serial_settings after the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Salva Peiró <speiro@ai2.upv.es> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/wan/wanxl.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index 6a24a5a70cc..4c0a69779b8 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
ifr->ifr_settings.size = size; /* data size wanted */
return -ENOBUFS;
}
+ memset(&line, 0, sizeof(line));
line.clock_type = get_status(port)->clocking;
line.clock_rate = 0;
line.loopback = 0;