summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorGregory Greenman <gregory.greenman@intel.com>2008-09-03 11:18:50 +0800
committerJohn W. Linville <linville@tuxdriver.com>2008-09-03 15:10:37 -0400
commit0b124c31838bcf0459708aa91ce859582c7d3ca1 (patch)
tree93d5e86d9396bb100425c4f7ba2cc8f75310c139 /drivers/net
parentd535311ecbba0d692b5f1278b8bcb2581c3482e0 (diff)
downloadlinux-3.10-0b124c31838bcf0459708aa91ce859582c7d3ca1.tar.gz
linux-3.10-0b124c31838bcf0459708aa91ce859582c7d3ca1.tar.bz2
linux-3.10-0b124c31838bcf0459708aa91ce859582c7d3ca1.zip
iwlwifi: fix STATUS_EXIT_PENDING is not set on pci_remove
This patch sets STATUS_EXIT_PENDING on pci_remove. Otherwise iwl4965_down may fail to uninitialize the driver. Signed-off-by: Gregory Greenman <gregory.greenman@intel.com> Signed-off-by: Mohamed Abbas <mohamed.abbas@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Zhu Yi <yi.zhu@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 4e3d6c7fd6d..e01f048a02d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -4372,15 +4372,18 @@ static void __devexit iwl4965_pci_remove(struct pci_dev *pdev)
iwl_dbgfs_unregister(priv);
sysfs_remove_group(&pdev->dev.kobj, &iwl4965_attribute_group);
+ /* ieee80211_unregister_hw call wil cause iwl4965_mac_stop to
+ * to be called and iwl4965_down since we are removing the device
+ * we need to set STATUS_EXIT_PENDING bit.
+ */
+ set_bit(STATUS_EXIT_PENDING, &priv->status);
if (priv->mac80211_registered) {
ieee80211_unregister_hw(priv->hw);
priv->mac80211_registered = 0;
+ } else {
+ iwl4965_down(priv);
}
- set_bit(STATUS_EXIT_PENDING, &priv->status);
-
- iwl4965_down(priv);
-
/* make sure we flush any pending irq or
* tasklet for the driver
*/