summaryrefslogtreecommitdiff
path: root/drivers/net/sky2.h
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@vyatta.com>2009-08-18 15:17:10 +0000
committerDavid S. Miller <davem@davemloft.net>2009-08-18 20:26:53 -0700
commit724b694225e711f95e6265afdbc304c9e7eb3721 (patch)
tree9fbad7f1126dee297108e943082ae565b7a72bac /drivers/net/sky2.h
parent6b84dacadbdc3dab6a5b313d20d5a93b0d998641 (diff)
downloadlinux-3.10-724b694225e711f95e6265afdbc304c9e7eb3721.tar.gz
linux-3.10-724b694225e711f95e6265afdbc304c9e7eb3721.tar.bz2
linux-3.10-724b694225e711f95e6265afdbc304c9e7eb3721.zip
sky2: no recycling
Recycling turns out to be a bad idea! For most use cases, the packet can not be reused: TCP packets are cloned. Even for the ideal case of forwarding, it hurts performance because of CPU ping/pong. On a multi-core system forwarding of 64 byte packets is worse much worse: recycling = 24% forwarded vs no recycling = 42% forwarded Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sky2.h')
-rw-r--r--drivers/net/sky2.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h
index 9d07a466aec..73c95471246 100644
--- a/drivers/net/sky2.h
+++ b/drivers/net/sky2.h
@@ -2032,7 +2032,6 @@ struct sky2_port {
u16 rx_pending;
u16 rx_data_size;
u16 rx_nfrags;
- struct sk_buff_head rx_recycle;
#ifdef SKY2_VLAN_TAG_USED
u16 rx_tag;