diff options
| author | Bruno Prémont <bonbons@linux-vserver.org> | 2012-07-30 21:38:57 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2012-08-15 10:13:26 +0200 |
| commit | a93ab8494873a88622bf74be861a93f875643524 (patch) | |
| tree | 19f76ccf334ffb78b387b10c047df61f44d8fa07 /drivers/hid/hid-picolcd_backlight.c | |
| parent | baacf9c5d2e631e7c940527ad670c8d4b019da81 (diff) | |
| download | linux-3.10-a93ab8494873a88622bf74be861a93f875643524.tar.gz linux-3.10-a93ab8494873a88622bf74be861a93f875643524.tar.bz2 linux-3.10-a93ab8494873a88622bf74be861a93f875643524.zip | |
HID: picoLCD: Improve unplug handling
Stop earlier attempting to submit new reports/URBs (though locking and
usbhid still prevents to bail out early enough to not produce multiple
hid-picolcd 0003:04D8:C002.0003: usb_submit_urb(out) failed: -19
messages in kernel log.
Strengthen framebuffer removal to be less racy.
Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-picolcd_backlight.c')
| -rw-r--r-- | drivers/hid/hid-picolcd_backlight.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hid/hid-picolcd_backlight.c b/drivers/hid/hid-picolcd_backlight.c index cd1ccd7205c..b91f30945f9 100644 --- a/drivers/hid/hid-picolcd_backlight.c +++ b/drivers/hid/hid-picolcd_backlight.c @@ -45,7 +45,8 @@ static int picolcd_set_brightness(struct backlight_device *bdev) data->lcd_power = bdev->props.power; spin_lock_irqsave(&data->lock, flags); hid_set_field(report->field[0], 0, data->lcd_power == FB_BLANK_UNBLANK ? data->lcd_brightness : 0); - usbhid_submit_report(data->hdev, report, USB_DIR_OUT); + if (!(data->status & PICOLCD_FAILED)) + usbhid_submit_report(data->hdev, report, USB_DIR_OUT); spin_unlock_irqrestore(&data->lock, flags); return 0; } |