diff options
author | Markus Armbruster <armbru@redhat.com> | 2006-06-26 00:24:34 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-26 09:58:17 -0700 |
commit | 0c6856f702732d3cfc33eb59303e998ad6961de8 (patch) | |
tree | 98d3c76586f6e63b4dc43a0f763e9b6a7cc4a984 /arch/mips/oprofile | |
parent | 57136ca6d57359c7f21a9bbb4a5a0a61eeb53f2b (diff) | |
download | linux-3.10-0c6856f702732d3cfc33eb59303e998ad6961de8.tar.gz linux-3.10-0c6856f702732d3cfc33eb59303e998ad6961de8.tar.bz2 linux-3.10-0c6856f702732d3cfc33eb59303e998ad6961de8.zip |
[PATCH] oprofile: Fix unnecessary cleverness
nmi_create_files() in arch/i386/oprofile/nmi_int.c depends on
model->num_counters (number of performance counters) being less than 10.
While this is currently the case, it's too clever by half.
Other archs aren't quite as clever: they assume 100. I suggest to
normalize them all to 1000.
Cc: Philippe Elie <phil.el@wanadoo.fr>
Cc: John Levon <levon@movementarian.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/mips/oprofile')
-rw-r--r-- | arch/mips/oprofile/common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/oprofile/common.c b/arch/mips/oprofile/common.c index c31e4cff64e..65eb55400d7 100644 --- a/arch/mips/oprofile/common.c +++ b/arch/mips/oprofile/common.c @@ -38,7 +38,7 @@ static int op_mips_create_files(struct super_block * sb, struct dentry * root) for (i = 0; i < model->num_counters; ++i) { struct dentry *dir; - char buf[3]; + char buf[4]; snprintf(buf, sizeof buf, "%d", i); dir = oprofilefs_mkdir(sb, root, buf); |