diff options
| author | Jan Kara <jack@suse.cz> | 2013-02-20 13:16:39 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-04 06:06:39 +0800 |
| commit | fa1c19bbbd6cb82086da10ae3817f8d5d8c6a7ae (patch) | |
| tree | 3bfda542220b4b4d29683ae6ceed8cf1278d019f | |
| parent | 316857e5fe5391057d5a05f215e01d0deff7c473 (diff) | |
| download | linux-3.10-fa1c19bbbd6cb82086da10ae3817f8d5d8c6a7ae.tar.gz linux-3.10-fa1c19bbbd6cb82086da10ae3817f8d5d8c6a7ae.tar.bz2 linux-3.10-fa1c19bbbd6cb82086da10ae3817f8d5d8c6a7ae.zip | |
ocfs2: fix possible use-after-free with AIO
commit 9b171e0c74ca0549d0610990a862dd895870f04a upstream.
Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.
Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ocfs2/aops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 657743254eb..340bd02839b 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -593,9 +593,9 @@ static void ocfs2_dio_end_io(struct kiocb *iocb, level = ocfs2_iocb_rw_locked_level(iocb); ocfs2_rw_unlock(inode, level); + inode_dio_done(inode); if (is_async) aio_complete(iocb, ret, 0); - inode_dio_done(inode); } /* |