diff options
| author | Joe Perches <joe@perches.com> | 2013-06-04 15:44:00 +0100 |
|---|---|---|
| committer | Jonathan Cameron <jic23@kernel.org> | 2013-06-04 18:28:21 +0100 |
| commit | e916b80d2b1988e985abc0a1c85eca5b96c61f48 (patch) | |
| tree | 33989028ad270fed5a1b6d3e4e2c864d77bac21a | |
| parent | 702df9f1819c7fc7e257251fabc5eec674342c32 (diff) | |
| download | linux-3.10-e916b80d2b1988e985abc0a1c85eca5b96c61f48.tar.gz linux-3.10-e916b80d2b1988e985abc0a1c85eca5b96c61f48.tar.bz2 linux-3.10-e916b80d2b1988e985abc0a1c85eca5b96c61f48.zip | |
inkern: iio_device_put after incorrect return/goto
The code uses
return foo;
goto err_type;
when instead the form should have been
ret = foo;
goto err_type;
Here this causes a useful iio_device_put to be skipped.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
| -rw-r--r-- | drivers/iio/inkern.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c index 795d100b4c3..dca4eed7b03 100644 --- a/drivers/iio/inkern.c +++ b/drivers/iio/inkern.c @@ -124,7 +124,7 @@ static int __of_iio_channel_get(struct iio_channel *channel, channel->indio_dev = indio_dev; index = iiospec.args_count ? iiospec.args[0] : 0; if (index >= indio_dev->num_channels) { - return -EINVAL; + err = -EINVAL; goto err_put; } channel->channel = &indio_dev->channels[index]; |