summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRonald G. Minnich <rminnich@gmail.com>2007-08-09 21:07:24 +1000
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-08-09 08:14:56 -0700
commite3bcf5e2785aa49f75f36a8d27d601891a7ff12b (patch)
tree8a79cd195751b325e4972ef1b53ff2cc5a9eb5fe
parent0d027c01cd36b8cff727c78d2e40d334ba9895a8 (diff)
downloadlinux-3.10-e3bcf5e2785aa49f75f36a8d27d601891a7ff12b.tar.gz
linux-3.10-e3bcf5e2785aa49f75f36a8d27d601891a7ff12b.tar.bz2
linux-3.10-e3bcf5e2785aa49f75f36a8d27d601891a7ff12b.zip
lguest: avoid shared libraries mapped over guest memory
Some versions of ld.so mmap the shared libraries right in over guest memory, so compile lguest statically by default. [ FC7 maps shared libraries very low, where the launcher maps guest's physical memory. Quick fix is to link Launcher static, real fix is for 2.6.24. ] -static is a simple fix. I expect this problem will be more common than we like, as different distro's make different "improvements" to ld.so Signed-off-by: Ronald G. Minnich <rminnich@gmail.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--Documentation/lguest/Makefile4
1 files changed, 3 insertions, 1 deletions
diff --git a/Documentation/lguest/Makefile b/Documentation/lguest/Makefile
index 31e794ef5f9..c0b7a455639 100644
--- a/Documentation/lguest/Makefile
+++ b/Documentation/lguest/Makefile
@@ -13,7 +13,9 @@ LGUEST_GUEST_TOP := ($(CONFIG_PAGE_OFFSET) - 0x08000000)
CFLAGS:=-Wall -Wmissing-declarations -Wmissing-prototypes -O3 -Wl,-T,lguest.lds
LDLIBS:=-lz
-
+# Removing this works for some versions of ld.so (eg. Ubuntu Feisty) and
+# not others (eg. FC7).
+LDFLAGS+=-static
all: lguest.lds lguest
# The linker script on x86 is so complex the only way of creating one