summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkalash nainwal <kalash.nainwal@gmail.com>2007-05-08 00:28:31 -0700
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-08 11:15:08 -0700
commit98701d1b0fe98b477b53df89114e6862547f8107 (patch)
tree4ccfe162116056c1af41563ef4ea6c93bb7067f3
parent0f95b7fc839bc3272b1bf2325d8748a649bd3534 (diff)
downloadlinux-3.10-98701d1b0fe98b477b53df89114e6862547f8107.tar.gz
linux-3.10-98701d1b0fe98b477b53df89114e6862547f8107.tar.bz2
linux-3.10-98701d1b0fe98b477b53df89114e6862547f8107.zip
(re)register_binfmt returns with -EBUSY
When a binary format is unregistered and re-registered, register_binfmt fails with -EBUSY. The reason is that unregister_binfmt does not set fmt->next to NULL, and seeing (fmt->next != NULL), register_binfmt fails with -EBUSY. One can find his way around by explicitly setting fmt->next to NULL after unregistering, but that is kind of unclean (one should better be using only the interfaces, and not the interal members, isn't it?) Attached one-liner can fix it. Signed-off-by: Kalash Nainwal <kalash.nainwal@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/exec.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/exec.c b/fs/exec.c
index f1691cd0c9d..1ba85c7fc6a 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -100,6 +100,7 @@ int unregister_binfmt(struct linux_binfmt * fmt)
while (*tmp) {
if (fmt == *tmp) {
*tmp = fmt->next;
+ fmt->next = NULL;
write_unlock(&binfmt_lock);
return 0;
}