summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSalva Peiró <speiro@ai2.upv.es>2013-12-17 10:06:30 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-01-15 15:28:48 -0800
commit8f3843be6e6d1fcc5bcdad42b569a5d4797d9d1f (patch)
tree6eaa73bef8927c3fa80ddf6f1fcd3ecdec9219be
parent2173ca37c090930f51f701fdd963b63fe2502789 (diff)
downloadlinux-3.10-8f3843be6e6d1fcc5bcdad42b569a5d4797d9d1f.tar.gz
linux-3.10-8f3843be6e6d1fcc5bcdad42b569a5d4797d9d1f.tar.bz2
linux-3.10-8f3843be6e6d1fcc5bcdad42b569a5d4797d9d1f.zip
hamradio/yam: fix info leak in ioctl
[ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ] The yam_ioctl() code fails to initialise the cmd field of the struct yamdrv_ioctl_cfg. Add an explicit memset(0) before filling the structure to avoid the 4-byte info leak. Signed-off-by: Salva Peiró <speiro@ai2.upv.es> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/hamradio/yam.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 0721e72f929..82529a2658d 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -1058,6 +1058,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
break;
case SIOCYAMGCFG:
+ memset(&yi, 0, sizeof(yi));
yi.cfg.mask = 0xffffffff;
yi.cfg.iobase = yp->iobase;
yi.cfg.irq = yp->irq;