summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLi Zefan <lizf@cn.fujitsu.com>2007-12-06 20:33:14 +1100
committerPaul Mackerras <paulus@samba.org>2007-12-20 17:13:34 +1100
commit6c6199c1551b7acd4f7898f073b40ae565d3b834 (patch)
tree5d69f734a8dae8430744ff9699ea331f42e70dff
parent9ac71d00398674aaec664f30559f0a21d963862f (diff)
downloadlinux-3.10-6c6199c1551b7acd4f7898f073b40ae565d3b834.tar.gz
linux-3.10-6c6199c1551b7acd4f7898f073b40ae565d3b834.tar.bz2
linux-3.10-6c6199c1551b7acd4f7898f073b40ae565d3b834.zip
[POWERPC] Don't cast a struct pointer to list_head pointer
The casting is safe only when the list_head member is the first member of the structure, and even then it is better to use the address of the list_head structure member. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Signed-off-by: Paul Mackerras <paulus@samba.org>
-rw-r--r--arch/ppc/syslib/ocp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c
index 3f5be2c5ce9..d42d4085dc8 100644
--- a/arch/ppc/syslib/ocp.c
+++ b/arch/ppc/syslib/ocp.c
@@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int function, int index)
down_write(&ocp_devices_sem);
dev = __ocp_find_device(vendor, function, index);
- list_del((struct list_head *)dev);
+ list_del(&dev->link);
up_write(&ocp_devices_sem);
DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... done.\n", vendor, function, index));