summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJesper Dangaard Brouer <hawk@comx.dk>2009-05-27 15:45:34 +0200
committerPatrick McHardy <kaber@trash.net>2009-05-27 15:45:34 +0200
commit683a04cebc63819a36b1db19843bd17771f05b55 (patch)
tree1d8770a96cdb13de12e297a99d03c6063320030d
parentb38b1f616867c832301f24eaf259889494d495b3 (diff)
downloadlinux-3.10-683a04cebc63819a36b1db19843bd17771f05b55.tar.gz
linux-3.10-683a04cebc63819a36b1db19843bd17771f05b55.tar.bz2
linux-3.10-683a04cebc63819a36b1db19843bd17771f05b55.zip
netfilter: xt_hashlimit does a wrong SEQ_SKIP
The function dl_seq_show() returns 1 (equal to SEQ_SKIP) in case a seq_printf() call return -1. It should return -1. This SEQ_SKIP behavior brakes processing the proc file e.g. via a pipe or just through less. Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> Signed-off-by: Patrick McHardy <kaber@trash.net>
-rw-r--r--net/netfilter/xt_hashlimit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index a5b5369c30f..219dcdbe388 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -926,7 +926,7 @@ static int dl_seq_show(struct seq_file *s, void *v)
if (!hlist_empty(&htable->hash[*bucket])) {
hlist_for_each_entry(ent, pos, &htable->hash[*bucket], node)
if (dl_seq_real_show(ent, htable->family, s))
- return 1;
+ return -1;
}
return 0;
}