summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-03-27 12:46:32 +0100
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2009-03-27 12:46:32 +0100
commit39375853d77bea48b7b334daa3698277af8d33f4 (patch)
treebaba0e374b4af037abb8a516f71f48dff3f4ab33
parente3d9a73a83d98fc466dabdcfe4f4e7e4419e3f8e (diff)
downloadlinux-3.10-39375853d77bea48b7b334daa3698277af8d33f4.tar.gz
linux-3.10-39375853d77bea48b7b334daa3698277af8d33f4.tar.bz2
linux-3.10-39375853d77bea48b7b334daa3698277af8d33f4.zip
ide: move smart_enable() call out from get_smart_data()
Move smart_enable() call out from get_smart_data() to proc_idedisk_read_smart(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r--drivers/ide/ide-disk_proc.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ide/ide-disk_proc.c b/drivers/ide/ide-disk_proc.c
index 1f86dcbd2b1..5766c1f62ad 100644
--- a/drivers/ide/ide-disk_proc.c
+++ b/drivers/ide/ide-disk_proc.c
@@ -31,7 +31,7 @@ static int get_smart_data(ide_drive_t *drive, u8 *buf, u8 sub_cmd)
tf->command = ATA_CMD_SMART;
args.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
args.data_phase = TASKFILE_IN;
- (void) smart_enable(drive);
+
return ide_raw_taskfile(drive, &args, buf, 1);
}
@@ -67,6 +67,8 @@ static int proc_idedisk_read_smart(char *page, char **start, off_t off,
ide_drive_t *drive = (ide_drive_t *)data;
int len = 0, i = 0;
+ (void)smart_enable(drive);
+
if (get_smart_data(drive, page, sub_cmd) == 0) {
unsigned short *val = (unsigned short *) page;
char *out = (char *)val + SECTOR_SIZE;