diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-14 08:47:35 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-15 15:19:10 -0700 |
| commit | 386d95b3ad6f6dad61d0be379873dca66595c1e4 (patch) | |
| tree | 33ccf0e3909a2a77503759629486d06a3e4943d9 | |
| parent | 640de636a1f149a92fe54f564ce931ec6b8418c6 (diff) | |
| download | linux-3.10-386d95b3ad6f6dad61d0be379873dca66595c1e4.tar.gz linux-3.10-386d95b3ad6f6dad61d0be379873dca66595c1e4.tar.bz2 linux-3.10-386d95b3ad6f6dad61d0be379873dca66595c1e4.zip | |
drivers/tty/moxa.c: fix error return code
Convert a 0 error return code to a negative one, as returned elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret;
expression e,e1,e2,e3,e4,x;
@@
(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
when != ret = e3
*if (x == NULL || ...)
{
... when != ret = e4
* return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/moxa.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index 9dffc724d46..3b17a044c21 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -977,6 +977,7 @@ static int __devinit moxa_pci_probe(struct pci_dev *pdev, board->basemem = ioremap_nocache(pci_resource_start(pdev, 2), 0x4000); if (board->basemem == NULL) { dev_err(&pdev->dev, "can't remap io space 2\n"); + retval = -ENOMEM; goto err_reg; } |