summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTorsten Kaiser <just.for.lkml@googlemail.com>2012-04-09 05:14:15 +0000
committerDavid S. Miller <davem@davemloft.net>2012-04-13 11:01:44 -0400
commit31304165ffb888483e0f7c805876f25f493a3049 (patch)
treefc3d9973f4887f47adf414df483fa466056352e7
parent89eb06f11c314c2ab4ec59039715dc021933a7a0 (diff)
downloadlinux-3.10-31304165ffb888483e0f7c805876f25f493a3049.tar.gz
linux-3.10-31304165ffb888483e0f7c805876f25f493a3049.tar.bz2
linux-3.10-31304165ffb888483e0f7c805876f25f493a3049.zip
net: Fix misplaced parenthesis in virtio_net.c
Commit 2e57b79ccef1ff1422fdf45a9b28fe60f8f084f7 misplaced its parenthesis and now tx_fifo_errors will only be incremented if an ENOMEM error is not written to the syslog. Correct the parenthesis and indentation to the original goal of counting all non ENOMEM errors and ratelimiting only the messages. Signed-of-by: Torsten Kaiser <just.for.lkml@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/virtio_net.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 4de2760c593..af8acc85f4b 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -626,16 +626,15 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)
/* This can happen with OOM and indirect buffers. */
if (unlikely(capacity < 0)) {
if (likely(capacity == -ENOMEM)) {
- if (net_ratelimit()) {
+ if (net_ratelimit())
dev_warn(&dev->dev,
"TX queue failure: out of memory\n");
- } else {
+ } else {
dev->stats.tx_fifo_errors++;
if (net_ratelimit())
dev_warn(&dev->dev,
"Unexpected TX queue failure: %d\n",
capacity);
- }
}
dev->stats.tx_dropped++;
kfree_skb(skb);