diff options
| author | David Woodhouse <dwmw2@infradead.org> | 2007-05-08 00:12:58 +0100 |
|---|---|---|
| committer | David Woodhouse <dwmw2@infradead.org> | 2007-05-20 11:30:38 -0400 |
| commit | 2ad8ee713566671875216ebcec64f2eda47bd19d (patch) | |
| tree | b8ad57ea0041b66b68eae2bb089f0c70b13a7ab9 | |
| parent | 8ae5d31263c746f1680d005b33a82d167cdb9eb6 (diff) | |
| download | linux-3.10-2ad8ee713566671875216ebcec64f2eda47bd19d.tar.gz linux-3.10-2ad8ee713566671875216ebcec64f2eda47bd19d.tar.bz2 linux-3.10-2ad8ee713566671875216ebcec64f2eda47bd19d.zip | |
[JFFS2] Fix potential memory leak of dead xattrs on unmount.
An xattr_datum which ends up orphaned should be freed by the GC
thread. But if we umount before the GC thread is finished, or if we
mount read-only and the GC thread never runs, they might never be
freed. Clean them up during unmount, if there are any left.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
| -rw-r--r-- | fs/jffs2/xattr.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c index 073469856d4..e48665984cb 100644 --- a/fs/jffs2/xattr.c +++ b/fs/jffs2/xattr.c @@ -754,6 +754,10 @@ void jffs2_clear_xattr_subsystem(struct jffs2_sb_info *c) list_del(&xd->xindex); jffs2_free_xattr_datum(xd); } + list_for_each_entry_safe(xd, _xd, &c->xattr_unchecked, xindex) { + list_del(&xd->xindex); + jffs2_free_xattr_datum(xd); + } } #define XREF_TMPHASH_SIZE (128) |