diff options
| author | Jean Delvare <jdelvare@suse.de> | 2012-01-28 11:07:09 +0100 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2012-02-03 09:34:03 +0000 |
| commit | 1849ecb22fb3b5d57b65e7369a3957adf9f26f39 (patch) | |
| tree | a325a93dabc97cfa2bc1fe192a69150e5a845c89 | |
| parent | 6d75e83ee31c146c8a3d56c762d3e15c483dc40e (diff) | |
| download | linux-3.10-1849ecb22fb3b5d57b65e7369a3957adf9f26f39.tar.gz linux-3.10-1849ecb22fb3b5d57b65e7369a3957adf9f26f39.tar.bz2 linux-3.10-1849ecb22fb3b5d57b65e7369a3957adf9f26f39.zip | |
drm/kms: Make i2c buses faster
A udelay value of 20 leads to an I2C bus running at only 25 kbps. I2C
devices can typically operate faster than this, 50 kbps should be fine
for all devices (and compliant devices can always stretch the clock if
needed.)
FWIW, the vast majority of framebuffer drivers set udelay to 10
already. So set it to 10 in DRM drivers too, this will make EDID block
reads faster. We might even lower the udelay value later if no problem
is reported.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Cc: Keith Packard <keithp@keithp.com>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/i915/intel_i2c.c | 2 | ||||
| -rw-r--r-- | drivers/gpu/drm/radeon/radeon_i2c.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c index d30ccccb9d7..7fa4f640e6f 100644 --- a/drivers/gpu/drm/i915/intel_i2c.c +++ b/drivers/gpu/drm/i915/intel_i2c.c @@ -37,7 +37,7 @@ /* Intel GPIO access functions */ -#define I2C_RISEFALL_TIME 20 +#define I2C_RISEFALL_TIME 10 static inline struct intel_gmbus * to_intel_gmbus(struct i2c_adapter *i2c) diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 98a8ad68010..b7ec89bf393 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -925,7 +925,7 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->algo.bit.setscl = set_clock; i2c->algo.bit.getsda = get_data; i2c->algo.bit.getscl = get_clock; - i2c->algo.bit.udelay = 20; + i2c->algo.bit.udelay = 10; /* vesa says 2.2 ms is enough, 1 jiffy doesn't seem to always * make this, 2 jiffies is a lot more reliable */ i2c->algo.bit.timeout = 2; |