summaryrefslogtreecommitdiff
path: root/ism/modules
diff options
context:
space:
mode:
authorJihoon Kim <jihoon48.kim@samsung.com>2018-02-06 18:59:05 +0900
committerJihoon Kim <jihoon48.kim@samsung.com>2018-02-06 10:07:10 +0000
commit27e25af9325a7e7539e14bdce623124341ecf0b9 (patch)
tree7b4c7b537a4b23a0957b28cc7e0267cb9bbd7941 /ism/modules
parent11180412f59de382721d4b7243d743990edcda17 (diff)
downloadisf-27e25af9325a7e7539e14bdce623124341ecf0b9.tar.gz
isf-27e25af9325a7e7539e14bdce623124341ecf0b9.tar.bz2
isf-27e25af9325a7e7539e14bdce623124341ecf0b9.zip
Fix defects detected by static analysis tool
Change-Id: I5c134d11420d8988b4f44811aab08ce4fde5fb2e Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Diffstat (limited to 'ism/modules')
-rw-r--r--ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp3
-rw-r--r--ism/modules/panelagent/wayland/isf_wsc_context.h2
2 files changed, 3 insertions, 2 deletions
diff --git a/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp b/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp
index 15c4e31d..b6e9d001 100644
--- a/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp
+++ b/ism/modules/panelagent/ecoresocket/ecore_socket_panel_agent_module.cpp
@@ -2948,7 +2948,6 @@ private:
if (m_info_manager->check_privilege_by_sockfd(client_id, IMEMANAGER_PRIVILEGE)) {
char* buf = NULL;
size_t len;
- bool ret = true;
//FIXME
//ret need be checked
@@ -2963,7 +2962,7 @@ private:
trans.clear();
trans.put_command(SCIM_TRANS_CMD_REPLY);
- trans.put_command(ret ? SCIM_TRANS_CMD_OK : SCIM_TRANS_CMD_FAIL);
+ trans.put_command(SCIM_TRANS_CMD_OK);
trans.write_to_socket(client_socket);
if (NULL != buf)
diff --git a/ism/modules/panelagent/wayland/isf_wsc_context.h b/ism/modules/panelagent/wayland/isf_wsc_context.h
index fda65dc4..6342432a 100644
--- a/ism/modules/panelagent/wayland/isf_wsc_context.h
+++ b/ism/modules/panelagent/wayland/isf_wsc_context.h
@@ -124,7 +124,9 @@ struct _WSCContextISF {
im_ctx(NULL),
surrounding_text_fd_read_handler(NULL),
selection_text_fd_read_handler(NULL),
+ remote_surrounding_text_fd_read_handler(NULL),
surrounding_text(NULL),
+ remote_surrounding_text(NULL),
selection_text(NULL),
preedit_str(NULL),
language(NULL),