diff options
author | Gilbok Lee <gilbok.lee@samsung.com> | 2019-08-08 17:38:48 +0900 |
---|---|---|
committer | Gilbok Lee <gilbok.lee@samsung.com> | 2019-08-08 18:02:26 +0900 |
commit | 06e20e75783032caa51dd70a74e20d98f85ccb82 (patch) | |
tree | 81d7788d70c9ed04e7231854b0fa71893e9be283 /src/mm_radio_priv_hal.c | |
parent | 2da5251b2a727ee17cdd1988c869195d316d788d (diff) | |
download | libmm-radio-06e20e75783032caa51dd70a74e20d98f85ccb82.tar.gz libmm-radio-06e20e75783032caa51dd70a74e20d98f85ccb82.tar.bz2 libmm-radio-06e20e75783032caa51dd70a74e20d98f85ccb82.zip |
Fix coverity issue (Unchecked return value)submit/tizen/20190809.005426accepted/tizen/unified/20190809.110824
[Version] 0.2.48
[Issue Type] Fix bugs
Change-Id: I15dbdc10a4f81fd9f748ab89a40444757bcd3ff4
Diffstat (limited to 'src/mm_radio_priv_hal.c')
-rw-r--r-- | src/mm_radio_priv_hal.c | 24 |
1 files changed, 17 insertions, 7 deletions
diff --git a/src/mm_radio_priv_hal.c b/src/mm_radio_priv_hal.c index c26be9a..b4d5f6e 100644 --- a/src/mm_radio_priv_hal.c +++ b/src/mm_radio_priv_hal.c @@ -321,13 +321,11 @@ int _mmradio_realize(mm_radio_t *radio) ret = sound_manager_create_stream_information_internal(SOUND_STREAM_TYPE_RADIO, NULL, radio, &radio->stream_info); if (ret != MM_ERROR_NONE) { MMRADIO_LOG_ERROR("failed to create stream information"); - MMRADIO_LOG_FLEAVE(); return ret; } ret = sound_manager_create_virtual_stream(radio->stream_info, &radio->vstream); if (ret != MM_ERROR_NONE) { MMRADIO_LOG_ERROR("sound_manager_create_virtual_stream error"); - MMRADIO_LOG_FLEAVE(); return ret; } @@ -348,17 +346,29 @@ int _mmradio_unrealize(mm_radio_t *radio) MMRADIO_CHECK_STATE_RETURN_IF_FAIL(radio, MMRADIO_COMMAND_UNREALIZE); /*Finish if there are scans*/ - _mmradio_stop_scan(radio); + ret = _mmradio_stop_scan(radio); + if (ret != MM_ERROR_NONE) + MMRADIO_LOG_WARNING("failed to stop radio scan"); /*Stop radio if started*/ - _mmradio_stop(radio); + ret = _mmradio_stop(radio); + if (ret != MM_ERROR_NONE) + MMRADIO_LOG_WARNING("failed to stop radio"); if (radio->vstream) { - sound_manager_destroy_virtual_stream(radio->vstream); + ret = sound_manager_destroy_virtual_stream(radio->vstream); + if (ret != SOUND_MANAGER_ERROR_NONE) { + MMRADIO_LOG_WARNING("failed to destory virtual stream information"); + return MM_ERROR_RADIO_INTERNAL; + } radio->vstream = NULL; } if (radio->stream_info) { - sound_manager_destroy_stream_information(radio->stream_info); + ret = sound_manager_destroy_stream_information(radio->stream_info); + if (ret != SOUND_MANAGER_ERROR_NONE) { + MMRADIO_LOG_WARNING("failed to destory virtual stream information"); + return MM_ERROR_RADIO_INTERNAL; + } radio->stream_info = NULL; } @@ -738,7 +748,7 @@ int _mmradio_seek(mm_radio_t *radio, MMRadioSeekDirectionType direction) MMRADIO_THREAD_LOCK(p_thread); - MMRADIO_LOG_INFO("trying to seek. direction[0:UP/1:DOWN) %d", direction); + MMRADIO_LOG_INFO("trying to seek. direction [%s]", direction ? "DOWN" : "UP"); radio->seek_direction = direction; p_thread->is_running = true; p_thread->stop = false; |