diff options
| author | Gilbok Lee <gilbok.lee@samsung.com> | 2020-09-16 10:37:56 +0900 |
|---|---|---|
| committer | Gilbok Lee <gilbok.lee@samsung.com> | 2020-09-16 10:37:57 +0900 |
| commit | 74a462e309a495d420bff3c1aabb45428a7362fc (patch) | |
| tree | 93f27c1e25ff35c875c42d9957f72fc610fdf12b /src/mm_player_priv.c | |
| parent | 88c7b7ae174c0de56c378c3ed15bd82bd1f74f85 (diff) | |
| download | libmm-player-74a462e309a495d420bff3c1aabb45428a7362fc.tar.gz libmm-player-74a462e309a495d420bff3c1aabb45428a7362fc.tar.bz2 libmm-player-74a462e309a495d420bff3c1aabb45428a7362fc.zip | |
[0.6.240] Fix coverity issuessubmit/tizen/20200916.082856accepted/tizen/unified/20200916.212654
- Missing unlock, Double free
Change-Id: Ied1781d04f3177a36762658c07e704a69edba382
Diffstat (limited to 'src/mm_player_priv.c')
| -rw-r--r-- | src/mm_player_priv.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 6b19906..8396f5f 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -3772,6 +3772,7 @@ __mmplayer_gst_create_plain_text_elements(mmplayer_t *player) LOGD("adding created elements to bin"); if (!_mmplayer_gst_element_add_bucket_to_bin(GST_BIN(textbin[MMPLAYER_T_BIN].gst), element_bucket)) { LOGE("failed to add elements"); + g_list_free(element_bucket); goto ERROR; } @@ -3783,6 +3784,7 @@ __mmplayer_gst_create_plain_text_elements(mmplayer_t *player) LOGD("Linking elements in the bucket by added order."); if (_mmplayer_gst_element_link_bucket(element_bucket) == -1) { LOGE("failed to link elements"); + g_list_free(element_bucket); goto ERROR; } @@ -3817,7 +3819,6 @@ __mmplayer_gst_create_plain_text_elements(mmplayer_t *player) return MM_ERROR_NONE; ERROR: - g_list_free(element_bucket); if (!player->play_subtitle && textbin[MMPLAYER_T_FAKE_SINK].gst) { LOGE("remove textbin sink from sink list"); |