diff options
| author | 이한종/On-Device Lab(SR)/Engineer/삼성전자 <hanjoung.lee@samsung.com> | 2019-06-20 13:55:57 +0900 |
|---|---|---|
| committer | 이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 <chunseok.lee@samsung.com> | 2019-06-20 13:55:57 +0900 |
| commit | c24d020e90607ac695d57dc5703f9b668952e347 (patch) | |
| tree | 34c5985f1e28063cb54623b4669a1d204f5b0c87 /docs | |
| parent | a12e60b18fbe4fb13143a526a01c904826ec8fc3 (diff) | |
| download | nnfw-c24d020e90607ac695d57dc5703f9b668952e347.tar.gz nnfw-c24d020e90607ac695d57dc5703f9b668952e347.tar.bz2 nnfw-c24d020e90607ac695d57dc5703f9b668952e347.zip | |
Revise HowToContribute.md (#5445)
Revise HowToContribute.md with our new reviewing process
Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/HowToContribute.md | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/docs/HowToContribute.md b/docs/HowToContribute.md index e62666998..a685c8e46 100644 --- a/docs/HowToContribute.md +++ b/docs/HowToContribute.md @@ -53,10 +53,16 @@ This section explains the steps to create a pull request (PR). 1. Request review - Please assign reviewers if you need review from them. Maintainers will honor your review request, - and accept your pull request only when all the reviewer approve your pull request. Note that this - does **NOT** mean that you should assign reviewers. Maintainers (or reviewers) will review your - pull request even without explicit review request. + It is recommended to assign reviewers yourself. Maintainers will honor your review request, + and accept your pull request only when + + - Approved by 1+ reviewers + - 0 rejection(Request Changes) + - 0 pending review request + - All the reviewers in the list must approve your pull request + + You can add/remove pending review requests in the middle of the review process. Maintainers + (or reviewers) could review your pull request even without explicit review request. 1. Update per feedback |