Fix gcc warning

delete line : unused variable.
strncpy : need null value space.

Change-Id: I71781d250828ad8c5ce44a29d0732bc8cb59c962
Signed-off-by: Kwang Son <k.son@samsung.com>

1 files changed, 37 insertions, 43 deletions

diff --git a/test/testsuites/common/video_helper/mv_video_helper.c b/test/testsuites/common/video_helper/mv_video_helper.c
index 67719486..2eb74481 100644
--- a/test/testsuites/common/video_helper/mv_video_helper.c
+++ b/test/testsuites/common/video_helper/mv_video_helper.c
@@ -205,34 +205,32 @@ int mv_video_reader_load(
 	image_data->image_width = info.width;
 	image_data->image_height = info.height;
 
-	/* Look to :
-	 * http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstvideo.html#GstVideoFormat */
 	switch (GST_VIDEO_FORMAT_INFO_FORMAT(info.finfo)) {
-	case(GST_VIDEO_FORMAT_GRAY8):
+	case GST_VIDEO_FORMAT_GRAY8:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_Y800;
 		break;
-	case(GST_VIDEO_FORMAT_I420):
+	case GST_VIDEO_FORMAT_I420:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_I420;
 		break;
-	case(GST_VIDEO_FORMAT_NV12):
+	case GST_VIDEO_FORMAT_NV12:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_NV12;
 		break;
-	case(GST_VIDEO_FORMAT_YV12):
+	case GST_VIDEO_FORMAT_YV12:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_YV12;
 		break;
-	case(GST_VIDEO_FORMAT_NV21):
+	case GST_VIDEO_FORMAT_NV21:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_NV21;
 		break;
-	case(GST_VIDEO_FORMAT_YUY2):
+	case GST_VIDEO_FORMAT_YUY2:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_YUYV;
 		break;
-	case(GST_VIDEO_FORMAT_UYVY):
+	case GST_VIDEO_FORMAT_UYVY:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_UYVY;
 		break;
-	case(GST_VIDEO_FORMAT_RGB):
+	case GST_VIDEO_FORMAT_RGB:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_RGB888;
 		break;
-	case(GST_VIDEO_FORMAT_RGBA):
+	case GST_VIDEO_FORMAT_RGBA:
 		image_data->image_colorspace = MEDIA_VISION_COLORSPACE_RGBA;
 		break;
 	default:
@@ -629,36 +627,36 @@ static int _mv_video_writer_link_internals(
 {
 	GstVideoInfo vinfo;
 	GstCaps *caps = NULL;
-	char format[6] = {0};
+	const char *format = NULL;
 
 	/* Convert from mv_colorspace to GstVideoFormat */
 	switch (writer->image_data.image_colorspace) {
-	case(MEDIA_VISION_COLORSPACE_Y800):
-		strncpy(format, "GRAY8", 5);
+	case MEDIA_VISION_COLORSPACE_Y800:
+		format = "GRAY8";
 		break;
-	case(MEDIA_VISION_COLORSPACE_I420):
-		strncpy(format, "I420", 4);
+	case MEDIA_VISION_COLORSPACE_I420:
+		format = "I420";
 		break;
-	case(MEDIA_VISION_COLORSPACE_NV12):
-		strncpy(format, "NV12", 4);
+	case MEDIA_VISION_COLORSPACE_NV12:
+		format = "NV12";
 		break;
-	case(MEDIA_VISION_COLORSPACE_YV12):
-		strncpy(format, "YV12", 4);
+	case MEDIA_VISION_COLORSPACE_YV12:
+		format = "YV12";
 		break;
-	case(MEDIA_VISION_COLORSPACE_NV21):
-		strncpy(format, "NV21", 4);
+	case MEDIA_VISION_COLORSPACE_NV21:
+		format = "NV21";
 		break;
-	case(MEDIA_VISION_COLORSPACE_YUYV):
-		strncpy(format, "YUY2", 4);
+	case MEDIA_VISION_COLORSPACE_YUYV:
+		format = "YUY2";
 		break;
-	case(MEDIA_VISION_COLORSPACE_UYVY):
-		strncpy(format, "UYVY", 4);
+	case MEDIA_VISION_COLORSPACE_UYVY:
+		format = "UYVY";
 		break;
-	case(MEDIA_VISION_COLORSPACE_RGB888):
-		strncpy(format, "RGB", 3);
+	case MEDIA_VISION_COLORSPACE_RGB888:
+		format = "RGB";
 		break;
-	case(MEDIA_VISION_COLORSPACE_RGBA):
-		strncpy(format, "RGBA", 4);
+	case MEDIA_VISION_COLORSPACE_RGBA:
+		format = "RGBA";
 		break;
 	default:
 		LOGE("Selected format %d is not supported",
@@ -732,7 +730,6 @@ static int _mv_video_writer_state_change(
 {
 	mv_video_writer_s *handle = (mv_video_writer_s *) writer;
 	GstStateChangeReturn state_ret = GST_STATE_CHANGE_FAILURE;
-	GstState pipeline_state = GST_STATE_NULL;
 
 	state_ret = gst_element_set_state(handle->pl,
 			state);
@@ -771,7 +768,6 @@ static GstFlowReturn appsink_newsample(
 		GstCaps *caps = gst_sample_get_caps(sample);
 		image_data_s im_data;
 		char *buffer = NULL;
-		unsigned int buffer_size = 0;
 
 		LOGD("Received sample from appsink");
 
@@ -784,34 +780,32 @@ static GstFlowReturn appsink_newsample(
 		im_data.image_width = vinfo.width;
 		im_data.image_height = vinfo.height;
 
-		/* Look to :
-		 * http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstvideo.html#GstVideoFormat */
 		switch (GST_VIDEO_FORMAT_INFO_FORMAT(vinfo.finfo)) {
-		case(GST_VIDEO_FORMAT_GRAY8):
+		case GST_VIDEO_FORMAT_GRAY8:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_Y800;
 			break;
-		case(GST_VIDEO_FORMAT_I420):
+		case GST_VIDEO_FORMAT_I420:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_I420;
 			break;
-		case(GST_VIDEO_FORMAT_NV12):
+		case GST_VIDEO_FORMAT_NV12:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_NV12;
 			break;
-		case(GST_VIDEO_FORMAT_YV12):
+		case GST_VIDEO_FORMAT_YV12:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_YV12;
 			break;
-		case(GST_VIDEO_FORMAT_NV21):
+		case GST_VIDEO_FORMAT_NV21:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_NV21;
 			break;
-		case(GST_VIDEO_FORMAT_YUY2):
+		case GST_VIDEO_FORMAT_YUY2:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_YUYV;
 			break;
-		case(GST_VIDEO_FORMAT_UYVY):
+		case GST_VIDEO_FORMAT_UYVY:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_UYVY;
 			break;
-		case(GST_VIDEO_FORMAT_RGB):
+		case GST_VIDEO_FORMAT_RGB:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_RGB888;
 			break;
-		case(GST_VIDEO_FORMAT_RGBA):
+		case GST_VIDEO_FORMAT_RGBA:
 			im_data.image_colorspace = MEDIA_VISION_COLORSPACE_RGBA;
 			break;
 		default: