diff options
| author | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2014-03-19 02:58:16 +0300 |
|---|---|---|
| committer | Simon Horman <horms+renesas@verge.net.au> | 2014-12-10 13:50:26 +0900 |
| commit | fb0c8852db885be505ccb75d7ace3d4648e8222a (patch) | |
| tree | ba2fa4ffa615a13489f55f3a690fd34a03f663d6 | |
| parent | 9bf3b993aeca308d322e62bf2dfa54563329fa28 (diff) | |
| download | renesas_kernel-fb0c8852db885be505ccb75d7ace3d4648e8222a.tar.gz renesas_kernel-fb0c8852db885be505ccb75d7ace3d4648e8222a.tar.bz2 renesas_kernel-fb0c8852db885be505ccb75d7ace3d4648e8222a.zip | |
micrel: fix masking off LED bits
Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the
obvious mistake when masking off the LED mode bits: forgot to do a logical NOT
to the mask with which it ANDs the register value, so that unrelated bits are
cleared instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 28bdc499d647124fa5844453d35e6f5d1b3810dc)
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
| -rw-r--r-- | drivers/net/phy/micrel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 0c9e4342f11..5ad971a55c5 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -167,7 +167,7 @@ static int kszphy_setup_led(struct phy_device *phydev, if (temp < 0) return temp; - temp &= 3 << shift; + temp &= ~(3 << shift); temp |= val << shift; rc = phy_write(phydev, reg, temp); |