Age | Commit message (Collapse) | Author | Files | Lines |
|
Once started, this service never runs twice.
Change-Id: Ic21b1f36467ce27cfd15ed0cede47b520735a522
|
|
- Create a link in documentation
- Add '.' at the end of @brief
- Add 'void' keyword inside parentheses
Change-Id: Ib92a3a3305a792d6c40ab127815766d838579b46
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Change-Id: I2fa33741c06a286968dc4c38d0e1a69202e93279
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Change-Id: Ib02e1fc6381dfe6f7a00561307d30119b78e4eca
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Change-Id: I85b4c82a96e42d3a08acd1ec3f2f25742205aa4e
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Fix an incorrect declaration to free the array unique_ptr.
Change-Id: I863708576482584156cd37f8e21aa824bdc7abb7
|
|
Change-Id: I84e8343338f07a8e2a9e817e1ccca221c98aeff6
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Change-Id: Ice751dae71952b2fa2452cb301a91eb4b28fa5e2
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
warning:
format '%llx' expects argument of type 'long long unsigned int*',
but argument has type 'uint64_t*' {aka 'long unsigned int*'}
Change-Id: I7e54040d62d10ebcf2084410bfbbd84310664e07
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
atrace_helper is an optional binary which can be pushed
onto the device running systrace in order to enrich
the traces with further details (memory, I/O, etc).
- Memory snapshots of runnig processes(PSS/RSS)
- Periodic snapshotting of processes and thread names.
- File paths for filesystem events (only inode numbers).
Base repo :
https://chromium.googlesource.com/catapult/+/refs/heads/master/systrace/atrace_helper/
Changed contents :
Remove specific logic related android
Change-Id: I84b6dff914d4d5f151003e002dd0ff08ab0ae81c
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Buffers, managed by malloc() and free(), are replaced with
std::unique_ptr type, so it will automatically deleted when going
out of scope.
Change-Id: I117bea7d0a980c94c0481f3e470da2a626ca4595
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Change-Id: I0bc2f11b1dff501b8dcfc84bbbad166a8a5d1b64
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Set the clock to the best available option while tracing. Use 'boot' if it's
available; otherwise, use 'mono'. If neither are available use 'global'.
Any write to the trace_clock sysfs file will reset the buffer, so only
update it if the requested value is not the current value.
Reference : https://www.kernel.org/doc/Documentation/trace/ftrace.txt
trace_clock:
Whenever an event is recorded into the ring buffer, a
"timestamp" is added. This stamp comes from a specified
clock. By default, ftrace uses the "local" clock. This
clock is very fast and strictly per cpu, but on some
systems it may not be monotonic with respect to other
CPUs. In other words, the local clocks may not be in sync
with local clocks on other CPUs.
Usual clocks for tracing:
# cat trace_clock
[local] global counter x86-tsc
The clock with the square brackets around it is the one
in effect.
local: Default clock, but may not be in sync across CPUs
global: This clock is in sync with all CPUs but may
be a bit slower than the local clock.
mono: This uses the fast monotonic clock (CLOCK_MONOTONIC)
which is monotonic and is subject to NTP rate adjustments.
boot: This is the boot clock (CLOCK_BOOTTIME) and is based on the
fast monotonic clock, but also accounts for time spent in
suspend. Since the clock access is designed for use in
tracing in the suspend path, some side effects are possible
if clock is accessed after the suspend time is accounted before
the fast mono clock is updated. In this case, the clock update
appears to happen slightly sooner than it normally would have.
Also on 32-bit systems, it's possible that the 64-bit boot offset
sees a partial update. These effects are rare and post
processing should be able to handle them. See comments in the
ktime_get_boot_fast_ns() function for more information.
Change-Id: Iba2d4fcd4f6272fd8faa2e7d462c5b275547c73f
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
nullptr is a keyword that can be used at all places
where NULL is expected. Like NULL, nullptr is implicitly
convertible and comparable to any pointer type.
Unlike NULL, it is not implicitly convertible or
comparable to integral types.
Change-Id: Ie1ea211adaff6f818d1f86b0e0a8d9736320b0bf
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
Add events based on kernel version 4.19.81.
Change-Id: I4b96d790b518dff794c5b2b06d6556e882d8b0c6
Signed-off-by: Seungha Son <seungha.son@samsung.com>
|
|
|
|
Change-Id: I8bc65b1d0767ad5cc940d6ebdb31cd622fca4c6f
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
Change-Id: I8bc65b1d0767ad5cc940d6ebdb31cd622fca4c6f
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
To mount tracefs needs to check existed path,
And add mount options in details.
Change-Id: I9393c5629b8bf423d48ecec51fd4d99418d421cc
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
'sys-kernel-debug-tracing.mount' was removed for
resolving 'systemctl --state failed' issue.
However, Add 'Options=remount,rw' to this file,
it can be solution also.
This reverts commit 0a2883bf7940b3ee138551434117d3ea63cbfb2a.
Change-Id: I5d7f4f5236f7212f06f41bd7ddf815c3f548c85a
|
|
When ttrace-marker.service is executed twice,
Second execution makes service failed because of
already generated tag file what generated correctly.
So, In this case(founding existed tag file)
initEnabledTagFile() will return true.
Change-Id: Ie4dbee288b1b8daa1231513a8be62bc6884e438b
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
Change-Id: I8f549274fcc65c8a4fb8c5f1c289874c281ed964
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
- Change permisstion of /tmp/ttrace_tag
root -> system_fw
- Assign User/Group to ttrace-marker.service
root -> system_fw
Change-Id: Ic48b0cfd347f56da2a052511e9e37edac539d033
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
- Add sys-kernel-debug-tracing.mount to replace
sys-kernel.tracing.service.
- This file can mount tracefs without
/bin/touch executable.
Change-Id: I035fc08243c95b09c39a70c46acecc758d7c7d1b
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
Assigning capabilities to sys-kernel-tracing.service causes
fail in Odroid U3+, Raspberry Pi3 at Tizen:Unified(5.0).
To resolve this issue, remove capabilities on tizen branch.
Change-Id: I437d1f005703c0ab6bc6e01aeaf5315138b47cbb
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
'cap_dac_override' capabilities used inteaded of
root permission of sys-kernel-tracing.service.
Change-Id: I71870eab4c2a32ac3a904f9713f0cb73a2295126
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
Used invalid type in printf(), change to correct type.
Many code lines did keep a indentation,
aligned indent for all of source codes.
Change-Id: I7cc0438d061c734b5356accd9ff9ff0801f64ff6
|
|
The sceanario of bootup-trace has vulnerability about
untrusted string loaded and execution.
This patch changes how to execution and remove system() calling.
And change open permission 0666 to 0600.
Change-Id: Ibfc19a9c8c7ef43af084e8d6b7496bf59c12dfe5
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
Add SmackProcessLabel=System at ttrace-marker.service.
Without this label,
ttrace-marker.service will be worked as System::Privileged,
This service is enough with System label.
Change-Id: I8d588822713a7c7a376f4cbc24e870f3c33bfdbd
Signed-off-by: joon.c.baek <joon.c.baek@samsung.com>
|
|
*For implicit declaration of function [-Wimplicit-function-declaration]
. Add #include <stdio.h> prior to use of the function vsnprintf.
*For Unused bariable [-Wunused-variable]
. Remove it. Really Unused.
. bufSize, buf, ret
*For Ignoring return value of func() [-Wunused-result]
. Remove the use of function by https://review.tizen.org/gerrit/#/c/124677/
Change-Id: I7e376cfc30078832141128d10b2e44cd598b9b56
|
|
This reverts commit f4dc8f8166d34463ac1cbe4750fcadf5f364fc83.
Change-Id: Ic13032fd562ef5b124e223bada29bd57f89f6b8b
|
|
|
|
|
|
4.x kernel splited traceFS and debugFS.
/sys/kernel/debug/tracing and /tmp should be mounted before
ttrace-marker.service started.
- Add sys-kernel-tracing.service to mount tracefs to /sys/kernel/debug/tracing
- Adjust ttrace-marker.service order to be after the sys-kernel-tracing.service
Change-Id: I48f08bb8d4a31fa24b8508307812241a6fcb73b6
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|
|
* warning: implicit declaration of function 'vsnprintf'
[-Wimplicit-function-declaration]
* warning: ignoring return value of 'int system(const char*)',
declared with attribute warn_unused_result [-Wunused-result]
Change-Id: Ie400cc8fea6b99d08ab935198b60ec1767ac75c6
|
|
Remove manual copy for license file in spec
Change-Id: Ie3288252dcf5f667d1bc3524439685d29fc18bfb
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|
|
tracing_init_dentry() auto-mount tracefs in kernel 4.10.x.
This initializing is triggered fs_initcall.
So, Removed code in this commit is meaningless.
Change-Id: I9ae499131d6f7a8d2dd6e6c2c2d09e33585e3bf6
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|
|
Change smack labeling to using systemd tmpfiles
instead of set_smacklabel() initializing
Change-Id: I0e44ea62200929804c745175f73cd469b9b4623e
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|
|
|
|
The libsmack function smack_setlabel is deprecated and will be removed.
Using the alternative instead.
Change-Id: Ia02383700175ba1e4eb91c85e4aa17c4033290f6
Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
|
|
I've assumed that Tizen 4.0 code is going to be more similar with 3.0
than 2.0.
Please do not rely on string == compare for version check.
Change-Id: I7465a0b1cd26de939f60190cf8e2227aa1e9e763
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
|
|
Change-Id: Icac243d8093e0460d74267d2a59e0e82c897163a
|
|
|
|
Change-Id: Ibdc1cef11acc258bfed7e61303b648ace77bfd1f
|
|
Change-Id: I4a0f580006ae18cc55901f912fc11ad999f5f3be
|
|
The dependancy with libstdc++ existed meaningless.
Remove depandancy using "-fno-exceptions" option.
Change-Id: I405922988bccebf5760be58586f98f5a392b319e
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|
|
Change-Id: Ice3dd142bb38b15fa331157d2b6b0ef9dd106b8e
|
|
Change-Id: Iaa3a46b5d6550e02d3d5ea66d0213e44a2048779
|
|
Attacker can exploit by modified 'PATH' environment.
Excuting system command have to use absolute path.
Change-Id: Ided661e83c072684524c5ab8b73fc89db9842e13
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|
|
Attacker can exploit by modified 'PATH' environment.
Excuting system command have to use absolute path.
Change-Id: Ided661e83c072684524c5ab8b73fc89db9842e13
Signed-off-by: Changjoon Baek <joon.c.baek@samsung.com>
|