diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2021-05-03 15:29:12 +0200 |
|---|---|---|
| committer | wanchao-xu <wanchao.xu@samsung.com> | 2024-01-09 19:56:14 +0800 |
| commit | 8fbf703d9172b2007ce49d2bdf12440d85a0335b (patch) | |
| tree | c7fe9b65f83e838925d8d50074f38ca0ead824c0 | |
| parent | 0b6e2a3ffa04b273b107ea3f84e5995c71bb5509 (diff) | |
| download | qemu-arm-static-8fbf703d9172b2007ce49d2bdf12440d85a0335b.tar.gz qemu-arm-static-8fbf703d9172b2007ce49d2bdf12440d85a0335b.tar.bz2 qemu-arm-static-8fbf703d9172b2007ce49d2bdf12440d85a0335b.zip | |
usb/redir: avoid dynamic stack allocation (CVE-2021-3527)
Git-commit: 7ec54f9eb62b5d177e30eb8b1cad795a5f8d8986
References: bsc#1186012, CVE-2021-3527
Use autofree heap allocation instead.
Fixes: 4f4321c11ff ("usb: use iovecs in USBPacket")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210503132915.2335822-3-kraxel@redhat.com>
Signed-off-by: Jose R Ziviani <jose.ziviani@suse.com>
| -rw-r--r-- | hw/usb/redirect.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index e0f5ca6f8..dd779c45d 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -607,7 +607,7 @@ static void usbredir_handle_iso_data(USBRedirDevice *dev, USBPacket *p, .endpoint = ep, .length = p->iov.size }; - uint8_t buf[p->iov.size]; + g_autofree uint8_t *buf = g_malloc(p->iov.size); /* No id, we look at the ep when receiving a status back */ usb_packet_copy(p, buf, p->iov.size); usbredirparser_send_iso_packet(dev->parser, 0, &iso_packet, @@ -805,7 +805,7 @@ static void usbredir_handle_bulk_data(USBRedirDevice *dev, USBPacket *p, usbredirparser_send_bulk_packet(dev->parser, p->id, &bulk_packet, NULL, 0); } else { - uint8_t buf[size]; + g_autofree uint8_t *buf = g_malloc(size); usb_packet_copy(p, buf, size); usbredir_log_data(dev, "bulk data out:", buf, size); usbredirparser_send_bulk_packet(dev->parser, p->id, @@ -910,7 +910,7 @@ static void usbredir_handle_interrupt_out_data(USBRedirDevice *dev, USBPacket *p, uint8_t ep) { struct usb_redir_interrupt_packet_header interrupt_packet; - uint8_t buf[p->iov.size]; + g_autofree uint8_t *buf = g_malloc(p->iov.size); DPRINTF("interrupt-out ep %02X len %zd id %"PRIu64"\n", ep, p->iov.size, p->id); |