| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
- rpmcliHashes*, and rpmcliProgress* and rpmcliPackagesTotal are
implementation details of rpmShowProgress() and are useless outside
of it. Make them static, these shouldn't have been exported to
begin with.
|
|
- Finding out which package provides a file with a given digest
is just .. useless functionality. Being next to useless is one
thing, but we pay a high price for this particular uselessness:
the index needed for this is one of the biggest and most expensive
indexes we have.
|
|
- Handle source rpm query as a new query source type RPMQV_SPECSRPM,
rename the binary query to RPMQV_SPECRPMS, with RPMQV_SPECFILE
as a backwards compatibility alias to RPMQV_SPECRPMS.
|
|
- For a library with just one public function this might seem like
a huge overkill but it permits cleanly separating dependencies:
nothing but package signing requires GnuPG. This lets the signing
support be stuffed into a separate package, avoiding having to
drag gpg in on every installation (signing isn't something everybody
does) and without having potentially broken interfaces in the API,
essentially solving RhBug:624585.
It also liberates signing to use libraries that might be off-limits
for the core rpm, such as perhaps in the future doing signing
by ourselves with the help of something like gpgme (which requires
far too many things to drag into core rpm).
|
|
|
|
- Enums are fine for defining the bitfield flags, but the bitfield
itself is not an enumeration. Add a separate typedef on "rpmFlags"
type (presenting a bitfield of flags) for all of these. Compilers
hardly care, but the typedefs give a nice visual clue for
us humans using these flags far away from ho^H^H definitions.
|
|
- These are internal only stuff and have no business being exported
in the API. Pass the iterators around in, duh, arguments as needed.
|
|
- This is an inconsistent oddball interface which only works for
limited query types, "cli" level API users are better off calling
rpmcliQuery() / rpmcliArgIter() instead
|
|
- This reverts commits 9ac127c35272772e0fc862608f4bde9748862b3d and
7abc26e300afd4da71f220db496f813571a37f5a
|
|
- The ts argument used to be necessary and used for rpmfiNew() and spec
query but not any more...
|
|
- This is really just an internal helper which only even works with
limited set of queries.
|
|
- Add popt exec aliases to rpmdb for backwards compatibility
- Change test-suite to use 'rpmdb --initdb' instead of 'rpm --initdb'
as popt exec aliases with absolute paths dont play very well
with the test-suite, duh...
|
|
- Add popt exec aliases to rpmkeys for backwards compatibility
|
|
- Since this is a rpmcliFoo() function, we can assume rpmcliInit()
is used and the verify disabling bits are set through the common
rpmcliQueryFlags set, making qva argument unnecessary.
|
|
- Add popt exec aliases to rpmsign for backwards compatibility (dejavu...)
|
|
- Avoid relying on the murky rpmLookupSignatureType() foobar on
low API level, pass the wanted tag explicitly from caller
- rpmLookupSignature(), rpmGetPassPhrase() + the bits they rely on
are now free of users within librpm itself
|
|
- Lose the "this has got something to do with signatures and stuff"
dispatcher mode, rpmcliSign() now only does what it says. It also
doesn't need transaction set for anything. It doesn't need much
else than files to operate on, what to do and possibly a passphrase.
It probably will need more when rpmLookupSignatureType()
is put out of its misery, but this'll do for now.
- Lose the now unnecessary passPhrase member from QVA_t
|
|
- Signature verification is completely different from package signing,
another step towards making rpmcliSign() do what it's named after
|
|
- Key import is completely different from package signing, first
step in detaching key import from rpmcliSign()
|
|
|
|
|
|
|
|
- Technically this changes the rpmcliQuery() and rpmcliVerify() API
in the sense that we no longer honor the qva->qva_flags for the
--nosignature and others, but we assume anybody using these (as if
anybody was using the "cli" API) uses rpmcliInit() which takes
care of these common bits... shrug.
- Ditch ancient and hidden --nopgp --nogpg switches along with the
dishwater which are simply alias to --nosignature.
- Eliminate now unused qva_flags from rpmInstallArguments (along with
a double vsflags goo from rpmgraph)
|
|
- none of this belongs to librpm headers and ABI
|
|
- Signing is better done in an environment completely separated from
the process of actually building packages. This is how its generally
done anyway by distros, this change just forces the issue.
- While signing on build seems handy and saves some io-churn, this
is very insecure as your precious secret passphrase remains unencrypted
in memory for the entire duration of the build where it's accessible
to whatever happens to be building. This change doesn't
affect fix the issue of unencrypted passphrase residing in memory
and potentially getting swapped out, it only limits the exposure
to the actual signing process which isn't subject to unknown scripts
poking around.
- Minimally preserve rpmbuild's --sign functionality via popt --pipe hack
to call rpm --addsign when build completes
|
|
- This hidden gem used "system hdlist", ie "/usr/share/comps/%{_arch}/hdlist
as the source for queries. Such "system hdlist" hasn't existed anywhere
since RHL 9/FC 1 times...
|
|
- that's what find + xargs are for, this is just useless cruft
|
|
- both are only ever assigned to with useless values and never read...
|
|
- add %verify(nofiledigest) as %verify(nomd5) file attribute alias
- reference digests as digests not checksums
- make old md5 related symbols obsolete and use newer reference
- update man page accordingly
|
|
transaction part from rpmInstall and rpmErase to rpmcliTransaction.
|
|
rpmInstallFlags_e.
|
|
- --usecatalog hasn't done anything in 10 years if ever afaict...
|
|
|
|
|
|
- ought to be safe as data is only ever automatically converted to larger
type on notify calls
|
|
|
|
- const on typedef'ed ARGV_t doesn't mean a thing, add a new,
(exec* compatible) ARGV_const_t and use where appropriate consistently in
argv.h, rpmcli.h etc
- popt's argv const is the wrong way around for exec() family, add explicit
ARGV_t casts on popGetArgs() uses where needed
- compiler silence, aaahh...
|
|
|
|
- not possible to do reliably within rpm
- effort is better wasted on investigating fs-level snapshots, which
is way beyond rpm scope except for hooks to interact with the snapshot
mechanism to communicate beginning/end of transaction and such
|
|
- most remaining [u]int16|32 uses are indexes and such, ie actual numbers
|
|
|
|
- preliminaries for bumping up the max size, use rpm-specific type
as off_t size varies, header data needs fixed size
|
|
- explicitly include what's really needed instead
- document remaining uses
|
|
- spec and cookie are malloced and need to be freed by caller
- unconst various other rpmQVK arguments & friends, no api exists to
free them so caller needs to handle anyway
|
|
- adjust include paths accordingly
|
|
|
|
|
|
- nothing needs it there, include directly where needed instead
|
|
- rpmmessages is empty, lose it
- adjust includes
|
|
|
