Age | Commit message (Collapse) | Author | Files | Lines |
|
- --root is valid for all the remaining modes, no point checking for it
- MODES_FOR_DBPATH is completely unused (and dbpath is a common option
to all anyway)
|
|
- We dont want new users to pick up using these old switches but
preserving functionality for backwards compatibility for now
|
|
- Track posix.fork() and only allow exit() and exec() if the script
has forked. There are other questionable items in posix extensions
too but these are the worst offenders.
- Using Lua registry for tracking forked status might be more Lua-way
option but this'll do for now.
|
|
|
|
- Use a separate table for the tool-specific options, include that from
the "master" option table to get option group summary in --help.
|
|
|
|
- It's a bad name for something that can also erase packages, leave
the install/upgrade/erase modes for /bin/rpm instead.
|
|
|
|
|
|
|
|
|
|
New status: 741 messages complete with 0 fuzzies and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
|
|
- The files are regenerated from scratch, involving header record
numbers moving around, possibly removing broken headers and all.
Don't pretend nothing changed when some changes almost certainly,
occurred, various API users rely on rpmdb mtime for determining
whether the db has changed since they last accessed it.
|
|
- It's been broken because of a typo for the last ten years and nobody
noticed, doesn't seem like a particularly useful switch...
|
|
|
|
- We already have the non-prefixed dbpath at hand, use that instead
of recalculating the path from the prefixed version
|
|
|
|
- mkdir() will error out with a reasonable error message of its
own, no point doing separate, buggy test with access()
|
|
|
|
- These have been no-ops since rpm 4.6, but might resurface one day so
leaving them around but out of sight...
|
|
- We always detect file conflicts (duh!) unless forced, no need for this
|
|
- This ensures its available in all our executables without adding
umphteen copies into rpmpopt (after the cli splits, this was missing
in eg rpmdb executable...)
|
|
|
|
|
|
|
|
- Changing db_api to db_ver to force breakage on anything using the
value, db_ver containing the BDB major version just to put something
in the error messages where the dbapi version used to be.
|
|
|
|
|
|
- We've only one dbapi and new ones are not around the corner. It
doesn't get tested and is likely broken at this point anyway,
better just kill it completely. We'll need a new mechanism
one day but lets worry about it when the day actually comes.
- Starting with eliminating dbapi arguments to the internal database
move helper
|
|
- These were used by the netsharedpath calculations which used
to be inline here, but that's now in a function of their own. Also
move the temporary variables to the scope where they're actually used.
|
|
- No point "documenting" with reverse ifdef's what somebody was
considering to implement eight years ago, as it is directory and
file iterations can't be mixed as they both mess with fi->j.
- Also eliminate pointless "can't happen" check - this never gets
called with NULL fi in an element (which is already a cant happen)
|
|
New status: 741 messages complete with 0 fuzzies and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
|
|
rpmdbIndexIteratorNext
|
|
|
|
|
|
iterator is pointing to
|
|
|
|
|
|
- Chainsaw relevant information out of rpm.8 and tweak a little bit,
adding cross-references etc. These will need a lot more love though...
|
|
|
|
|
|
- This has been unused at least as far back as rpm 4.4 actually...
|
|
- These were used, back in the day, to implement a hidden --specedit
switch, which in all its glory did: print a copy of a spec file,
with group, summary and description looked up from specspo.
This huge pile of junk was left behind from kicking out the
useless "feature" in commits 7b95061d3b77d8e6b3c80e856b66f49b393511ba and
0f991a14209054da7c45c46e96750738fc62874d.
|
|
The elfdeps doesn't parse the whole .gnu.version_d section.
For example:
$ readelf -V /lib/libbz2.so.1 | grep -A3 .gnu.version_d
Version definition section '.gnu.version_d' contains 2 entries:
Addr: 0x0000000000000884 Offset: 0x000884 Link: 4 (.dynstr)
000000: Rev: 1 Flags: BASE Index: 1 Cnt: 1 Name: libbz2.so.1
0x001c: Rev: 1 Flags: none Index: 2 Cnt: 1 Name: BZLIB_1.0
Before changes:
$ echo /lib/libbz2.so.1.0.6 | /usr/lib/rpm/elfdeps -P
libbz2.so.1
After changes:
$ echo /lib/libbz2.so.1.0.6 | /usr/lib/rpm/elfdeps -P
libbz2.so.1(BZLIB_1.0)
libbz2.so.1
Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
|
|
- rpmParseState uses might actually qualify for a true enum here
but changing it would require changing half of librpmbuild and
many of them mix the parse states, other error codes and whatnot
in their types... just not worth the trouble, so use an int.
|
|
|
|
- The string from getStringBuf() is not modified, so use a const
variable for it, and a separate variable for the temporary
line splitting for triggers
|
|
- addChangelog() is a bad boy and modifies the string it grabs
from getStringBuf(), be clean about it and grab a copy through
argvJoin() instead
- addChangelog() would be better off walking and parsing over the
argv directly instead of a joined string of it all, but leaving
that exercise for some other rainy day
|
|
- Similar to commit 1e3db59b568b1ff7f7e1f3285fc9b18567f2f2d6,
no point using temporary string buffer when only end up splitting
it into an argv for processing. Incidently this would've been
a much less intrusive fix to RhBug:573339 than introducing
a whole new argvSplitString() function... oh well. Take care not
to introduce extra newlines in the process as argvSplitString() was
eating them before - need to use appendStringBuf() for spec->prep now.
|
|
- doScript() doesn't do anything special with the script buffer,
this lets us use const for the argument.
|