Optimize header data python conversion for array tags a bit

- We know the array size beforehand, allocate the entire array
  at once and set the elements instead of appending one by one.
  This is (an obvious) and well-measurable, if not a huge, win.

1 files changed, 4 insertions, 4 deletions

diff --git a/python/rpmtd-py.c b/python/rpmtd-py.c
index 026f6c711..7655755f0 100644
--- a/python/rpmtd-py.c
+++ b/python/rpmtd-py.c
@@ -43,18 +43,18 @@ PyObject *rpmtd_AsPyobj(rpmtd td)
     }
     
     if (array) {
-	res = PyList_New(0);
+	int ix;
+	res = PyList_New(rpmtdCount(td));
         if (!res) {
             return NULL;
         }
-	while (rpmtdNext(td) >= 0) {
+	while ((ix = rpmtdNext(td)) >= 0) {
 	    PyObject *item = rpmtd_ItemAsPyobj(td, tclass);
             if (!item) {
                 Py_DECREF(res);
                 return NULL;
             }
-	    PyList_Append(res, item);
-	    Py_DECREF(item);
+	    PyList_SET_ITEM(res, ix, item);
 	}
     } else {
 	res = rpmtd_ItemAsPyobj(td, tclass);