summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPanu Matilainen <Panu Matilainen pmatilai@redhat.com>2011-07-07 13:55:16 +0300
committerPanu Matilainen <Panu Matilainen pmatilai@redhat.com>2011-07-07 13:55:16 +0300
commit3688b39cab92af6840d541c60582bd327954ff50 (patch)
tree68c2efac32d198ef11967dd04b1e369ca0c9b297
parent78c95448a16f0c766e1fdd34db861b8150335484 (diff)
downloadlibrpm-tizen-3688b39cab92af6840d541c60582bd327954ff50.tar.gz
librpm-tizen-3688b39cab92af6840d541c60582bd327954ff50.tar.bz2
librpm-tizen-3688b39cab92af6840d541c60582bd327954ff50.zip
Eliminate fdNew() from the API
- Nobody should be able to create file descriptors which are not attached to a file/descriptor of some kind, the only sane fd constructors are Fopen(), Fdopen() and fdDup(). - The same applies to fdFree() but its a bit more complicated, punting that till later...
-rw-r--r--rpmio/rpmio.c2
-rw-r--r--rpmio/rpmio.h4
2 files changed, 1 insertions, 5 deletions
diff --git a/rpmio/rpmio.c b/rpmio/rpmio.c
index daec2e9b0..f04748fa9 100644
--- a/rpmio/rpmio.c
+++ b/rpmio/rpmio.c
@@ -198,7 +198,7 @@ static const FDIO_t lzdio;
* Update digest(s) attached to fd.
*/
static void fdUpdateDigests(FD_t fd, const void * buf, size_t buflen);
-
+static FD_t fdNew(void);
/**
*/
int _rpmio_debug = 0;
diff --git a/rpmio/rpmio.h b/rpmio/rpmio.h
index f43192f36..986194f64 100644
--- a/rpmio/rpmio.h
+++ b/rpmio/rpmio.h
@@ -114,10 +114,6 @@ FD_t fdLink(void * cookie);
*/
FD_t fdFree(FD_t fd);
-/** \ingroup rpmio
- */
-FD_t fdNew (void);
-
/**
*/
int ufdCopy(FD_t sfd, FD_t tfd);