diff options
| author | Panu Matilainen <pmatilai@redhat.com> | 2012-03-07 14:31:42 +0200 |
|---|---|---|
| committer | Panu Matilainen <pmatilai@redhat.com> | 2012-03-07 14:34:34 +0200 |
| commit | 1b729439c647e7f99a0b2c5df4ae96f3af50f2f4 (patch) | |
| tree | 250a0cb8ffc739dcb8472605b2b9f5fa1c9a2366 | |
| parent | 95fe0d53d4ce1436468e191a52bf2cdf8ff31e68 (diff) | |
| download | librpm-tizen-1b729439c647e7f99a0b2c5df4ae96f3af50f2f4.tar.gz librpm-tizen-1b729439c647e7f99a0b2c5df4ae96f3af50f2f4.tar.bz2 librpm-tizen-1b729439c647e7f99a0b2c5df4ae96f3af50f2f4.zip | |
Revert to former spec query behavior + comment
- Various tools expect to get the full package list, not just those
that would actually be built. There are of just as valid reasons
for only wanting the packages that would be built, but we need
to make this caller specifiable, just changing the behavior breaks
existing tools unnecessarily. Add reminder comment why the thing
is the way it is...
| -rw-r--r-- | build/spec.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/build/spec.c b/build/spec.c index d0bf9ff78..85af03cff 100644 --- a/build/spec.c +++ b/build/spec.c @@ -407,7 +407,14 @@ int rpmspecQuery(rpmts ts, QVA_t qva, const char * arg) if (qva->qva_source == RPMQV_SPECRPMS) { res = 0; for (Package pkg = spec->packages; pkg != NULL; pkg = pkg->next) { +#if 0 + /* + * XXX FIXME: whether to show all or just the packages that + * would be built needs to be made caller specifiable, for now + * revert to "traditional" behavior as existing tools rely on this. + */ if (pkg->fileList == NULL) continue; +#endif res += qva->qva_showPackage(qva, ts, pkg->header); } } else { |