diff options
| author | Panu Matilainen <pmatilai@redhat.com> | 2011-04-21 10:13:45 +0300 |
|---|---|---|
| committer | Panu Matilainen <pmatilai@redhat.com> | 2011-04-21 10:44:09 +0300 |
| commit | 96c4f818a5676cb87c930fb15ad0a243ea3cbd80 (patch) | |
| tree | 58f95f1f099d349aad0cfab39b7d8d662d0ba66c | |
| parent | 29fffe9aa5e91d21e06e00f338937359e683f6a4 (diff) | |
| download | librpm-tizen-96c4f818a5676cb87c930fb15ad0a243ea3cbd80.tar.gz librpm-tizen-96c4f818a5676cb87c930fb15ad0a243ea3cbd80.tar.bz2 librpm-tizen-96c4f818a5676cb87c930fb15ad0a243ea3cbd80.zip | |
Just ignore miFreeHeader() return on rpmdbNextIterator() too
- There's no meaningful way to return a write-error here,
rpmdbNextIterator() caller wouldn't know whether NULL at termination
is early due to error or not. So just ignore the return from
miFreeHeader(), it can only fail on rewrite mode (ie markReplacedFiles())
so impact is rather limited anyway.
| -rw-r--r-- | lib/rpmdb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/rpmdb.c b/lib/rpmdb.c index 04a5a0ae7..096fb3dcd 100644 --- a/lib/rpmdb.c +++ b/lib/rpmdb.c @@ -1679,7 +1679,6 @@ Header rpmdbNextIterator(rpmdbMatchIterator mi) void * keyp; size_t keylen; int rc; - int xx; if (mi == NULL) return NULL; @@ -1779,7 +1778,7 @@ top: } /* Rewrite current header (if necessary) and unlink. */ - xx = miFreeHeader(mi, dbi); + miFreeHeader(mi, dbi); /* Is this the end of the iteration? */ if (uh == NULL) |