diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2011-11-24 19:33:31 +0100 |
|---|---|---|
| committer | Andrzej Zaborowski <balrog@zabor.org> | 2011-12-05 21:38:44 +0100 |
| commit | 02afbf64753fcf95f3b0b36cf4066ba194ec550d (patch) | |
| tree | 68c2b7f7c593b76576cf20afe191de38b391cc27 /target-arm | |
| parent | 4abc7ebf5f00bb53439e2923cd47f7642491abf8 (diff) | |
| download | qemu-02afbf64753fcf95f3b0b36cf4066ba194ec550d.tar.gz qemu-02afbf64753fcf95f3b0b36cf4066ba194ec550d.tar.bz2 qemu-02afbf64753fcf95f3b0b36cf4066ba194ec550d.zip | |
target-arm/translate.c: Fix slightly misleading comment in Thumb decoder
Clarify some slightly misleading comments in the Thumb decoder's
handling of the memory hint space -- in particular one code path
marked as 'UNPREDICTABLE or unallocated hint' also includes some
legitimate preload instructions.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
Diffstat (limited to 'target-arm')
| -rw-r--r-- | target-arm/translate.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/target-arm/translate.c b/target-arm/translate.c index 0f35b60946..f91553a48a 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -9025,14 +9025,16 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1) goto illegal_op; } if (rn == 15) { - /* UNPREDICTABLE or unallocated hint */ + /* UNPREDICTABLE, unallocated hint or + * PLD/PLDW/PLI (literal) + */ return 0; } if (op1 & 1) { - return 0; /* PLD* or unallocated hint */ + return 0; /* PLD/PLDW/PLI or unallocated hint */ } if ((op2 == 0) || ((op2 & 0x3c) == 0x30)) { - return 0; /* PLD* or unallocated hint */ + return 0; /* PLD/PLDW/PLI or unallocated hint */ } /* UNDEF space, or an UNPREDICTABLE */ return 1; |