diff options
author | Avi Kivity <avi@redhat.com> | 2010-11-17 11:50:09 +0200 |
---|---|---|
committer | Anthony Liguori <aliguori@us.ibm.com> | 2010-11-21 09:16:57 -0600 |
commit | acd1c812b5548c8426e093075362b6d4119db6ac (patch) | |
tree | 0cc07f3a9b3d7dbeb29c95d4e56754a8d4a77afa /ioport.h | |
parent | 94b0b5ff5f5c3ab946fa926d464738edb3713ed4 (diff) | |
download | qemu-acd1c812b5548c8426e093075362b6d4119db6ac.tar.gz qemu-acd1c812b5548c8426e093075362b6d4119db6ac.tar.bz2 qemu-acd1c812b5548c8426e093075362b6d4119db6ac.zip |
Type-safe ioport callbacks
The current ioport callbacks are not type-safe, in that they accept an "opaque"
pointer as an argument whose type must match the argument to the registration
function; this is not checked by the compiler.
This patch adds an alternative that is type-safe. Instead of an opaque
argument, both registation and the callback use a new IOPort type. The
callback then uses container_of() to access its main structures.
Currently the old and new methods exist side by side; once the old way is gone,
we can also save a bunch of memory since the new method requires one pointer
per ioport instead of 6.
Acked-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'ioport.h')
-rw-r--r-- | ioport.h | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -25,6 +25,7 @@ #define IOPORT_H #include "qemu-common.h" +#include "iorange.h" typedef uint32_t pio_addr_t; #define FMT_pioaddr PRIx32 @@ -36,6 +37,7 @@ typedef uint32_t pio_addr_t; typedef void (IOPortWriteFunc)(void *opaque, uint32_t address, uint32_t data); typedef uint32_t (IOPortReadFunc)(void *opaque, uint32_t address); +void ioport_register(IORange *iorange); int register_ioport_read(pio_addr_t start, int length, int size, IOPortReadFunc *func, void *opaque); int register_ioport_write(pio_addr_t start, int length, int size, |