diff options
author | Kirill Batuzov <batuzovk@ispras.ru> | 2014-07-01 15:52:32 +0400 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2014-07-06 09:13:54 +0300 |
commit | 812c1057f6175ac9a9829fa2920a2b5783814193 (patch) | |
tree | b12d8756b1ce00662d4b910c5b02c1a539ff6f02 /include/hw/char | |
parent | 85d1277e668106294d134a101729c6f36289da1a (diff) | |
download | qemu-812c1057f6175ac9a9829fa2920a2b5783814193.tar.gz qemu-812c1057f6175ac9a9829fa2920a2b5783814193.tar.bz2 qemu-812c1057f6175ac9a9829fa2920a2b5783814193.zip |
Handle G_IO_HUP in tcp_chr_read for tcp chardev
Since commit cdaa86a54b232572bba594bf87a7416e527e460c
("Add G_IO_HUP handler for socket chardev")
GLib limitation results in a bug on Windows host. Steps to reproduce:
Start qemu: qemu-system-i386 -qmp tcp:127.0.0.1:4444:server:nowait
Connect with telnet: telnet 127.0.0.1 4444
Try sending some data from telnet.
Expected result: answers from QEMU.
Observed result: no answers (actually tcp_chr_read is not called at all).
Due to GLib limitations it is not possible to create several watches on one
channel on Windows hosts. See bug #338943 in GNOME bugzilla for details:
https://bugzilla.gnome.org/show_bug.cgi?id=338943
This reimplements commit cdaa86a54b232572bba594bf87a7416e527e460c
("Add G_IO_HUP handler for socket chardev") using a single watch:
Handle G_IO_HUP in tcp_chr_read instead. It is already watched by a
corresponding watch. Remove the second watch with its handler.
Cc: Antonios Motakis <a.motakis@virtualopensystems.com>
Cc: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Kirill Batuzov <batuzovk@ispras.ru>
Signed-off-by: Nikita Belov <zodiac@ispras.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'include/hw/char')
0 files changed, 0 insertions, 0 deletions