diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2014-05-12 12:04:20 +0300 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2014-05-12 12:07:21 +0300 |
| commit | 937251408051e0489f78e4db3c92e045b147b38b (patch) | |
| tree | 45cab79b85deef399ccc216012fdb5a2dc44aeef /hw/virtio/virtio.c | |
| parent | 06b4f00d53637f2c16a62c2cbaa30bffb045cf88 (diff) | |
| download | qemu-937251408051e0489f78e4db3c92e045b147b38b.tar.gz qemu-937251408051e0489f78e4db3c92e045b147b38b.tar.bz2 qemu-937251408051e0489f78e4db3c92e045b147b38b.zip | |
virtio: allow mapping up to max queue size
It's a loop from i < num_sg and the array is VIRTQUEUE_MAX_SIZE - so
it's OK if the value read is VIRTQUEUE_MAX_SIZE.
Not a big problem in practice as people don't use
such big queues, but it's inelegant.
Reported-by: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/virtio/virtio.c')
| -rw-r--r-- | hw/virtio/virtio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 7f4e7eca0e..3557c178f1 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -430,7 +430,7 @@ void virtqueue_map_sg(struct iovec *sg, hwaddr *addr, unsigned int i; hwaddr len; - if (num_sg >= VIRTQUEUE_MAX_SIZE) { + if (num_sg > VIRTQUEUE_MAX_SIZE) { error_report("virtio: map attempt out of bounds: %zd > %d", num_sg, VIRTQUEUE_MAX_SIZE); exit(1); |