diff options
author | Markus Armbruster <armbru@redhat.com> | 2013-07-31 15:11:06 +0200 |
---|---|---|
committer | Anthony Liguori <anthony@codemonkey.ws> | 2013-09-12 11:45:31 -0500 |
commit | 0628c18267bbe8d44f0faf3e71acf0ae31bea7fd (patch) | |
tree | ffbbcdc9034feb27d11ed645cadd965c80baaf5b /exec.c | |
parent | dfeaf2abc73429171ecc5b0b26ac4e5a24c047fc (diff) | |
download | qemu-0628c18267bbe8d44f0faf3e71acf0ae31bea7fd.tar.gz qemu-0628c18267bbe8d44f0faf3e71acf0ae31bea7fd.tar.bz2 qemu-0628c18267bbe8d44f0faf3e71acf0ae31bea7fd.zip |
exec: Clean up fall back when -mem-path allocation fails
With -mem-path, qemu_ram_alloc_from_ptr() first tries to allocate
accordingly, but when it fails, it falls back to normal allocation.
The fall back allocation code used to be effectively identical to the
"-mem-path not given" code, until it started to diverge in commit
432d268. I believe the code still works, but clean it up anyway: drop
the special fall back allocation code, and fall back to the ordinary
"-mem-path not given" code instead.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Message-id: 1375276272-15988-3-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <anthony@codemonkey.ws>
Diffstat (limited to 'exec.c')
-rw-r--r-- | exec.c | 7 |
1 files changed, 2 insertions, 5 deletions
@@ -1117,15 +1117,12 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host, if (mem_path) { #if defined (__linux__) && !defined(TARGET_S390X) new_block->host = file_ram_alloc(new_block, size, mem_path); - if (!new_block->host) { - new_block->host = qemu_anon_ram_alloc(size); - memory_try_enable_merging(new_block->host, size); - } #else fprintf(stderr, "-mem-path option unsupported\n"); exit(1); #endif - } else { + } + if (!new_block->host) { if (kvm_enabled()) { /* some s390/kvm configurations have special constraints */ new_block->host = kvm_ram_alloc(size); |