diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2013-04-05 11:32:20 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2013-04-05 18:58:05 +0200 |
| commit | ae29d6c64bd8d55873a2cb1df50ae4321b497447 (patch) | |
| tree | d677532c07fcb19a2f6708eecaa185f63e92d8da /blockdev.c | |
| parent | 5905fbc9c94ccd744c1b249472eafcc2d827548a (diff) | |
| download | qemu-ae29d6c64bd8d55873a2cb1df50ae4321b497447.tar.gz qemu-ae29d6c64bd8d55873a2cb1df50ae4321b497447.tar.bz2 qemu-ae29d6c64bd8d55873a2cb1df50ae4321b497447.zip | |
block: keep I/O throttling slice time constant
It is not necessary to adjust the slice time at runtime. We already
extend the current slice in order to carry over accounting into the next
slice. Changing the actual slice time value introduces oscillations.
The guest may experience large changes in throughput or IOPS from one
moment to the next when slice times are adjusted.
Reported-by: Benoît Canet <benoit@irqsave.net>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-By: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/blockdev.c b/blockdev.c index 8cdc9ce16a..6dc999d802 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1069,7 +1069,6 @@ void qmp_block_set_io_throttle(const char *device, int64_t bps, int64_t bps_rd, } bs->io_limits = io_limits; - bs->slice_time = BLOCK_IO_SLICE_TIME; if (!bs->io_limits_enabled && bdrv_io_limits_enabled(bs)) { bdrv_io_limits_enable(bs); |