diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2012-03-23 13:34:50 +0100 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2012-04-17 10:23:27 +0200 |
| commit | f5bf14bf39ec1ca2ad70ca1ec0e38a3e1e3f252d (patch) | |
| tree | c6f38543fe5767cf0874bfaa3a9cfa595548dfa5 | |
| parent | 39c20577009731d5e059db10ef269807b57e498d (diff) | |
| download | qemu-f5bf14bf39ec1ca2ad70ca1ec0e38a3e1e3f252d.tar.gz qemu-f5bf14bf39ec1ca2ad70ca1ec0e38a3e1e3f252d.tar.bz2 qemu-f5bf14bf39ec1ca2ad70ca1ec0e38a3e1e3f252d.zip | |
usb_packet_set_state: handle p->ep == NULL
usb_packet_set_state can be called with p->ep = NULL. The tracepoint
there tries to log endpoint information, which leads to a segfault.
This patch makes usb_packet_set_state handle the NULL pointer properly.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | hw/usb/core.c | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/hw/usb/core.c b/hw/usb/core.c index a4048fe3e0..9a14a53852 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -484,12 +484,17 @@ void usb_packet_check_state(USBPacket *p, USBPacketState expected) void usb_packet_set_state(USBPacket *p, USBPacketState state) { - USBDevice *dev = p->ep->dev; - USBBus *bus = usb_bus_from_device(dev); - - trace_usb_packet_state_change(bus->busnr, dev->port->path, p->ep->nr, p, - usb_packet_state_name(p->state), - usb_packet_state_name(state)); + if (p->ep) { + USBDevice *dev = p->ep->dev; + USBBus *bus = usb_bus_from_device(dev); + trace_usb_packet_state_change(bus->busnr, dev->port->path, p->ep->nr, p, + usb_packet_state_name(p->state), + usb_packet_state_name(state)); + } else { + trace_usb_packet_state_change(-1, "", -1, p, + usb_packet_state_name(p->state), + usb_packet_state_name(state)); + } p->state = state; } |