summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYonit Halperin <yhalperi@redhat.com>2012-03-18 09:42:39 +0200
committerGerd Hoffmann <kraxel@redhat.com>2012-03-19 13:12:19 +0100
commit6ec5dae5a49f2933dc9b3925d8054eb380a56d88 (patch)
tree0716a499563b2a304a536e148ffb909277cbfa98
parentd0638b185c92a3fa8c82c2ef229312e9dbbd555c (diff)
downloadqemu-6ec5dae5a49f2933dc9b3925d8054eb380a56d88.tar.gz
qemu-6ec5dae5a49f2933dc9b3925d8054eb380a56d88.tar.bz2
qemu-6ec5dae5a49f2933dc9b3925d8054eb380a56d88.zip
monitor: fix client_migrate_info error handling
Report QERR_MISSING_PARAMETER when port is missing. Otherwise QERR_UNDEFINED_ERROR will occur. rhbz #795652 Signed-off-by: Yonit Halperin <yhalperi@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
-rw-r--r--monitor.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/monitor.c b/monitor.c
index d57e7bf61d..8f460317ee 100644
--- a/monitor.c
+++ b/monitor.c
@@ -880,6 +880,11 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict,
return -1;
}
+ if (port == -1 && tls_port == -1) {
+ qerror_report(QERR_MISSING_PARAMETER, "port/tls-port");
+ return -1;
+ }
+
ret = qemu_spice_migrate_info(hostname, port, tls_port, subject,
cb, opaque);
if (ret != 0) {